1812461 - Update CFR popups to be sticky unless explicitly dismissed

Status: RESOLVED FIXED

(Firefox for Android :: Onboarding, task, P2)

Description

[Jeff Boek [:boek]]

From github: https://github.com/mozilla-mobile/fenix/issues/27033.

Title

During our investigations in Focus and planning, UX observed that our CFRs were not sticky and can therefore be dismissed unintentionally when trying to (for example) interact with web content and then miss important information.

Description

The CFRPopup has the flag dismissOnClickOutside (defaulted to true) which we can flip to ensure the popup is not mistakenly dismissed.

Deliverables

List all the CFR pops we have and investigate with UX which ones need to sticky or not.

cc: @jeffreygee

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Joe M [:jmahon]]

The language in this bug might be outdated. It looks like :jeffreygee summarized UX intentions at the end of the original Github ticket, per this.

If I'm reading that correctly, the result of the spike is "yes, CFR popups should be sticky until explicitly dismissed". I'm going to update this bug to represent that decision, but if I'm misinterpreting it, anyone is certainly welcome to help correct me - thanks!

Guideline from Jeff G:

After discussing with the team, here's our intended CFR behavior:

• is dismissed when user hits close button (X) or action on CFR (i.e. href)
• is not dismissed with an outside click
• is not dismissed when the screen is rotated. @Mugurell's proposal (One approach we could try is still dismissing the CFR when the screen rotates but maybe after a small delay show it again.) seems like a good option to mediate this.
• if user leaves and comes back, return user to last state (i.e. if user closes app during onboarding and re-opens, user should return to last state and see CFR again)
• has no scrim behind it so the user isn't taken out of the experience
• close button (X) has a touch target that follows accessibility guidelines (48x48dp on android, 44x44px on iOS)

Let me know if any questions. Happy to discuss! @Mugurell

Comment 3

[Chris Peterson [:cpeterson]]

The recording in bug 1819949 comment 0 appears to show the CFR in the same Y position when the screen rotates between landscape to portrait orientation. Should the CFR move to the address bar at the bottom of the page in portrait orientation? What happens when the CFR is first shown in portrait orientation and then rotated to landscape orientation?

Comment 4

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1812461 - Update CFR Popups to be sticky (#1162)

Comment 5

[Vlad Dreghici [:vdreghici]]

The behavior of CFRs that use the CFRPopup from AC has been changed and now behave according to what Jeff G said here: https://github.com/mozilla-mobile/fenix/issues/27033#issuecomment-1302363014 . Also you can check it in the first video I attached.
The remaining problem here is the private browsing recommendation popup window, which is not using our CFRPopup composable, instead it is using the Android Popup Window widget (https://github.com/mozilla-mobile/fenix/blob/9822a2d65bdc29ec69a6918f77d229d097f39d9c/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt#L820=L860).
Currently this popup:

• is automatically dismissed with an outside click
• is not dismissed when the screen is rotated.

See second video for reference.
Currently I am working on finding a solution for this PopupWindow to behave as the CFRs do, if that won't work, a future proof solution would be to migrate it to a CFR as well.

Comment 6

[Vlad Dreghici [:vdreghici]]

Attachment: First video.mp4

Comment 7

[Vlad Dreghici [:vdreghici]]

Attachment: PrivateBrowsing.mp4

Comment 8

[Vlad Dreghici [:vdreghici]]

Removed [needs-ux] since the behavior is clear after having a discussion with the team.

Comment 9

[Vlad Dreghici [:vdreghici]]

Migrating the Popup for recommending Private Browsing Shortcut led to a slight change in its UI. Because of this, I am requesting approval from UX/UI for the following changes. Check before and after pictures below:

Comment 10

[Vlad Dreghici [:vdreghici]]

Attachment: Before.png

A screenshot of the private browsing recommendation popup before migration to CFRPopup

Comment 11

[Vlad Dreghici [:vdreghici]]

Attachment: After.png

A screenshot of the private browsing recommendation popup after migration to CFRPopup.

Comment 12

[Joe M [:jmahon]]

:vlad, is the only difference the slight change in visual appearance? (No behavior changes?)

If so, to accelerate the completion of this bug, I'm comfortable making an executive decision on behalf of the design team, this is fine to move forward with.

Comment 13

[Chris Peterson [:cpeterson]]

(In reply to Joe M [:jmahon] from comment #12)

:vlad, is the only difference the slight change in visual appearance? (No behavior changes?)

If so, to accelerate the completion of this bug, I'm comfortable making an executive decision on behalf of the design team, this is fine to move forward with.

^

Comment 14

[Chris Peterson [:cpeterson]]

This bug might be nice to fix before we ship Fakespot in 119 so users don't accidentally dismiss the Fakespot CFR. This CFR might be the only in-product notification of the Fakespot feature.

Comment 15

[Vlad Dreghici [:vdreghici]]

(In reply to Joe M [:jmahon] from comment #12)

:vlad, is the only difference the slight change in visual appearance? (No behavior changes?)

If so, to accelerate the completion of this bug, I'm comfortable making an executive decision on behalf of the design team, this is fine to move forward with.

Perfect, I'll return to this and finish it!

Comment 16

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/691a984877328105681d0db9b669abcae7575c11
[main] Bug 1812461 - Update CFR Popups to be sticky

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/ca590af10048f2a969a1cb6578e6fe908b336741
[main] Bug 1812461 - Prevent Cookie Banner dismissal by back press

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/b6e5fa62022ccd87e93c35995f2941ec44fb1a51
[main] Bug 1812461 - Migrate private browsing recommend PopupWindow to CFRPopup

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/13dd78e8ed01aebeb840a3b620c220b3ef57df75
[main] Bug 1812461 - Add option to hide CFRPopup dismissal button

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/da04915c542e02c146f2ae1b7fe8f6f4220a6229
[main] Bug 1812461 - Add compose test tags & ignore failing tests

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/afe25e2fd9b282d043e0ca09b669c0418ee2304c
[main] Bug 1812461 - Migrate TCP CFR Tests to compose

Comment 17

[Adina Petridean QA [:apetridean]]

Verified as fixed on Nightly 119.0a1 from 15.09.2023 with Google Pixel 7 Pro ( Android 14) and Motorola Moto G9 plus (Android 11).
The pop-up is dismissed in accordance with the guidelines from Jeff G (comment 3).

Comment 18

[Adina Petridean QA [:apetridean]]

Attachment: popups.mp4