1812605 - Android Firefox nightly file upload is broken

Status: VERIFIED FIXED

(Fenix :: General, defect, P1)

Description

[steven]

User Agent: Mozilla/5.0 (Android 9; Mobile; rv:109.0) Gecko/109.0 Firefox/109.0
Firefox for Android

Steps to reproduce:

Version
111.0a1 (Build #2015929707), 3b6e77338+
AC: 111.0.20230125190040, 8703d67632
GV: 111.0a1-20230125094200
AS: 96.3.0

Go to a website such as
https://postimages.org/

Then try uploading a file.

Actual results:

After selecting the file from my phone's file system nothing happens.

Expected results:

The file would be selected.

Comment 1

[rdz_bug]

Same here

Android 12 Galaxy S20 FE

Comment 2

[Andrei Mocirean]

Hello!

Thanks for submitting the issue. I can confirm that the issue is reproducible on the latest Nightly build from 27th of January 2023 (111.0a1).
The issue is a Nightly specific issue, as it cannot be reproduced on the latest Firefox RC (109.1.1) nor latest Firefox Beta (110.0b4).

Tested on:

• Google Pixel 6 (Android 13)
• Oppo Find X3 Neo (Android 11)
• Samsung Galaxy S22 Ultra (Android 13)
• Huawei P40 Lite (Android 10)

Comment 3

[Ksenia Berezina [:ksenia]]

This is likely the same issue as bug1813470

Comment 4

[Kevin Brosnan [Ex-Mozilla]]

This was from 2020, file uploads were working.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Testing GVE would be useful. If it reproduces in GVE it should get bisected by MozRegression.

Comment 7

[Ksenia Berezina [:ksenia]]

Attachment: Screenshot_20230130-203200.png

It's reproducible in GVE, however reproducible as far as 2021 (not sure if GVE showing the permission request to get access to files at all, therefore I was always getting the same result).

I was able to run mozregression by manually adjusting permissions in Settings to allow "Photos and videos" before uploading (it's under "Not allowed"). In this case I got the following range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=51bf1455bb63aa6bd69f39d2a1cbf27f631d0fa3&tochange=e775219bd7886ea5e71a4d30eff8314f25c28beb

In cases when it breaks, "Photos and videos" option is not in the list of App permissions (see attached screenshot). In cases when it works, the option is present, and I could move it to "Allowed" and upload the files.

Looking at the pushlog, bug1771343 could be related?

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

:olivia, since you are the author of the regressor, bug 1771343, could you take a look?

For more information, please visit auto_nag documentation.

Comment 9

[Olivia Hall [:olivia]]

Hi, I think it could be Android 13 related. I'm not sure of how well file upload works in GVE because of bug 1591640 and bug 1620301, but the manual permissions make sense. It also makes sense that it works different for photo files.

One thing that comes to mind is this discussion on mime types and scoped storage for upgrading to Android 13 in Android Components.

Is this only happening for certain accept upload filetypes, for example file uploads that are pictures?

:mcarare might have more info too.

Comment 10

[Ksenia Berezina [:ksenia]]

Attachment: 1812605.html

(In reply to Olivia Hall [:olivia] from comment #9)

Hi, I think it could be Android 13 related. I'm not sure of how well file upload works in GVE because of bug 1591640 and bug 1620301, but the manual permissions make sense. It also makes sense that it works different for photo files.

One thing that comes to mind is this discussion on mime types and scoped storage for upgrading to Android 13 in Android Components.

Is this only happening for certain accept upload filetypes, for example file uploads that are pictures?

:mcarare might have more info too.

Thanks for looking into this!

To answer the question about accept types, this is the accept used on the site in this bugreport: image/*,application/pdf,.heic,.heif.
From bug1813470, reports mention that videos also can't be accepted.

I've added a testcase with a few accept types that don't work (images, video, pdf, .doc/.docx).

Comment 11

[Mihai Adrian Carare [:mcarare]]

Since this reproduces on devices with Android versions than 13, it is highly unlikely to be an Android 13-related issue.
Also, from the reports, it seems that you can actually access the file picker, which rules out not having storage-related permissions, otherwise, the picker would just not show up.

As this issue is not reproducible on Focus, I also doubt that is an AC or even Gecko-related issue. It is most likely that the regression is caused by a commit in Fenix.

Will come back with the regression range and start investigating a solution.

Comment 12

[Mihai Adrian Carare [:mcarare]]

Regression commit: https://github.com/mozilla-mobile/fenix/pull/28351/commits/b3b03f9207614cb1a57454005501dc4044bd4cfe

Comment 13

[BMO Automation]

Attachment: [mozilla-mobile/fenix] Bug 1812605 - Continue to handle activity results from AC startActivityForResult calls. (#28713)

Comment 15

[Adina Petridean]

Verified as fixed on Nightly 111.0a1 from 02/02 with Motorola Moto G9 plus (Android 11).
The file is selected and uploaded.

Comment 16

[Adina Petridean]

Attachment: upload.JPEG