1812631 - [HCM] Screenshot overlay's download button focus style needs correction

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P3)

Description

[Cieara Meador [:cmkm] (she/her)]

Attachment: macos_contrast_focus_kb.png

STR: (Windows 11, macOS)

1. Toggle OS HCM theme (Win11) or Increased Contrast mode (macOS)
2. Set screenshots.browser.component.enabled = true
3. Open the screenshots overlay (Cmd/Ctrl+Shift+S) and click either 'Save visible' or 'Save full page'
4. Using the tab key, focus the Download button
5. Note background color and SVG icon color is inconsistent with focus styles of the other buttons, and difficult to discern

Comment 1

[Cieara Meador [:cmkm] (she/her)]

Attachment: win11_focus_kb.png

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1812631 - Use shared icons for screenshots buttons. r=sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d0d5de3be6e
Use shared icons for screenshots buttons. r=sfoster

Comment 4

[Iulian Moraru]

Backed out for causing multiple mochitest failures.

• Push with failures

• Failure log

• Backout link

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/278ccbdd45ba
Use shared icons for screenshots buttons. r=sfoster

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/278ccbdd45ba

Comment 7

[Ardelean Oana, Desktop QA [:oardelean]]

Reproducible on a 2023-03-29 Nightly build on Windows 10.
Verified as fixed on Firefox 113.0b6(build ID: 20230420180037) and Nightly 114.0a1(build ID: 20230420212414) on Windows 10, Ubuntu 22, macOS 12.