1812644 - Event::PreventDefaultInternal should call WarnOnceAbout only once.

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Current a string is created and destroyed always, and that requires allocation/deallocation.
https://searchfox.org/mozilla-central/rev/e35e7107299a46a696b8aa8a4a5c03a39458ac21/dom/base/Document.cpp#13358 anyhow returns then early.

Having if (!doc->HasWarnedAbout(Document::ePreventDefaultFromPassiveListener)) before WarnOnceAbout should work.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1812644 - Event::PreventDefaultInternal should call WarnOnceAbout only once, r=masayuki

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

This is probably the only place where WarnOnceAbout is called in such a hot code, so I didn't try to change the API, at least not for now.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb9e29f74b61
Event::PreventDefaultInternal should call WarnOnceAbout only once, r=masayuki

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/fb9e29f74b61