1812646 - base-loader.js should be loaded in the devtools global when used for browser toolbox

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Alexandre Poirot [:ochameau]]

It looks like this module has never been loaded in the distinct system compartment for the browser toolbox usages. It has been loaded as a JSM for a little while/ever:
https://searchfox.org/mozilla-central/rev/e35e7107299a46a696b8aa8a4a5c03a39458ac21/devtools/shared/loader/Loader.sys.mjs#9-11

Unfortunately, this can cause various subtle troubles in the debugger if we are triggering code from this module while being paused. Surprisingly, we don't trigger base loader code so much while being paused in the current setup. We do that a lot more with bug 1648499!

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1812646 - [devtools] Convert base-loader JSM to ESM.

Having it be a JSM make it so that part of the loader is still using the
shared loader global, which can cause various troubles in the browser toolbox.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc9c41a684ad
[devtools] Convert base-loader JSM to ESM. r=devtools-reviewers,jdescottes

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/cc9c41a684ad