1812661 - [wpt-sync] Sync PR 38201 - Reland "Propagate tree scope to keyframes"

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38201 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38201
Details from upstream follow.

Xiaocheng Hu <[e-mail]> wrote:

Reland "Propagate tree scope to keyframes"

This reverts commit 373f528bb6dc316aaf9ce0ef308ed8e7005a0d97.

Reason for reland: Changed Member to WeakMember to prevent leak

Original change's description:

Revert "Propagate tree scope to keyframes"

This reverts commit 50c25ed46796e593de8358b69af78127fde1c8e9.

Reason for revert: Suspect for blink_wpt_tests and blink_web_tests failing on WebKit Linux Leak builder
i.e. https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/47313/overview

Original change's description:

Propagate tree scope to keyframes

As a follow up patch of crrev.com/c/4167268, this patch resolves
tree-scopes references in keyframes by propagating the tree scope
to the keyframes, and use that to create tree-scope-populated
CSSValues for interpolations.

Change-Id: I4cb21b0fbfdc9d8072ad77705ae3516c52e41df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4167011
Commit-Queue: Xiaocheng Hu \<[e-mail]>
Reviewed-by: Anders Hartvoll Ruud \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1097028}

Change-Id: I23493cd16574750061a5c1a8764e8a8a09ddc448
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4196234
Auto-Submit: Nidhi Jaju \<[e-mail]>
Owners-Override: Nidhi Jaju \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Nidhi Jaju \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1097181}

Change-Id: I474612b06dc9a6becdcfb04a8c81147d82f05467
Cq-Include-Trybots: luci.chromium.try:layout_test_leak_detection,linux-wpt-content-shell-leak-detection

Reviewed-on: https://chromium-review.googlesource.com/4198375
WPT-Export-Revision: 800dc47b2de68c0fa30e5d20b3a20b77c949a786

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=65f4e15f3ec6e4a94b166206ca245eaea76aeb41

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

PASS: 1
FAIL: 1

Chrome

FAIL: 2

Safari

FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-scoping/scoped-reference-animation-002.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15e4adc0f3c5
[wpt PR 38201] - Reland "Propagate tree scope to keyframes", a=testonly
https://hg.mozilla.org/integration/autoland/rev/ecb4e949819b
[wpt PR 38201] - Update wpt metadata, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/15e4adc0f3c5
https://hg.mozilla.org/mozilla-central/rev/ecb4e949819b