(In reply to Emilio Cobos Álvarez (:emilio) from comment #17)
(In reply to Paul Bone [:pbone] from comment #15)
I can confirm my title bar is missing since Bug 1812289. But I just noticed the buttons are now on the right in the line of tabs. But it took me half the day to find the buttons (looks like the xfce screenshot in comment 11). This caused me some confusion because things like this are sometimes hard for me to notice and find on the screen - I have poor eyesight. So although this is intentional change, I'd like to provide some feedback to be weighed against the benefits of this change:
- it's the kind of change that could cause confusion for some users, either with low vision or who had become accustomed to the previous layout.
That's fair. However this is the default Firefox behavior in every other platform (windows / macOS have done that by default since forever).
Yeah, I understand. I think I've seen it on Windows but I didn't notice on MacOS, I just checked, More MacOS apps draw in their title bar area so I hadn't noticed it. I think my "surprise" comes from it being "a change" and different from many other apps on Cinnamon.
- Some functionality is accessed by right-clicking on the title bar, the area for those clicks is now smaller and more difficult to click - equally difficult as the close/minimise/maximise buttons are.
Right-clicking in the titlebar should show the native menu, see bug 1771950.
Yeah, I can find that, I just have to click the area all the way to the right because I have many tabs.
- it's different from (almost?) every other application on my computer. I expect more programs to have a similar look and feel on the same OS rather than having to learn new patterns/behaviours for different programs on the same computer.
That also really applies to other DEs but the GNOME default was for a long time drawing on the titlebar...
As for possible paths forward we could:
- Back out the patch and restore the previous default; Document it as an intentional default pointing to this bug. It's a bit weird to have different defaults for different desktop environments that are capable of doing CSD, but maybe it's ok.
- Write a migration to avoid changing behavior in existing profiles, but keep the new default for new profiles.
- Maybe something else I'm not thinking of?
I think I'd prefer the second option, if only because it brings (long term) consistency across DEs that support CSD at least... Thoughts Martin?
I also like #2. If you were to back out the patch then that would mean Firefox would behave differently on different DEs, which seems more odd than differently on different OSs.
Would #1 or #2 have the problem that we must maintain codepaths for CSD and non-CSD?
My preferred option would be if DEs had a global option that apps like Firefox could check, like some do for dark/light mode. So that when I'm picking my desktop theme/window decorations/etc I can also choose if I want to enable this and that more (but probably not all) apps change their behaviour. I don't see an option for that in Linux Mint's settings though.
Thanks for considering my feedback Emilio.