1812730 - Collections with empty name can be created

Status: RESOLVED FIXED

(Firefox for Android :: Collections, defect, P3)

Description

[Jeff Boek [:boek]]

From github: https://github.com/mozilla-mobile/fenix/issues/27089.

Steps to reproduce

1. Launch the FIrefox application.
2. Open a few tabsand from the tabs tray, tap the "Select tabs" button.
3. Select one/more tabs. Tap the save to collection icon.
4. Delete the "Collection 1" name and tap on OK button.
5. Check the name of the new collection.

Expected behaviour

Collections with empty name can be created

Actual behaviour

Collections with empty name cannot be created. An error message is displayed.

Device name

One Plus 9 PRO

Android version

Android 12

Firefox release type

Firefox Nightly

Firefox version

Firefox Nightly 107.0a1 09/21

Device logs

No response

Additional information

Related bug that was previously fixed
This issue is also reproducible on Firefox Beta 106.0b1 and RC 105.1.0
Please note a collection also can be created by pressing on space, with emoji or using invalid characters (. , * , < , > , ? , \ , , : ).
This issue is also repro on Nightly 107.0a1 - 09/21.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[happinessmncube]

I would like to work on this issue, is there any message that has to be displayed to the user. If so what is the message?

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to happinessmncube from comment #1)

I would like to work on this issue

Thanks for your help! I can assign this bug to you while you work on it.

Do you have a local build of Firefox Android running on a device or emulator?

https://firefox-source-docs.mozilla.org/contributing/build/building_mobile_firefox.html

is there any message that has to be displayed to the user. If so what is the message?

I tried to reproduce this bug and I see that the current UI doesn't allow an empty collection name. However, when I tap the keyboard's "Done" when trying to enter the empty name (or just whitespace), the keyboard closes, but the empty collection name field is still open. This is confusing. Can we disable the keyboard's "Done" button while the collection name is an empty string or just whitespace?

Comment 3

[Chris Peterson [:cpeterson]]

If you have questions about building or running Firefox Android, drop by the #mobile-dev channel on Mozilla's Matrix server:

https://chat.mozilla.org/?#/room/#mobile-dev:mozilla.org

Comment 4

[happinessmncube]

(In reply to Chris Peterson [:cpeterson] from comment #2)

(In reply to happinessmncube from comment #1)

I would like to work on this issue

Thanks for your help! I can assign this bug to you while you work on it.

Do you have a local build of Firefox Android running on a device or emulator?

https://firefox-source-docs.mozilla.org/contributing/build/building_mobile_firefox.html

is there any message that has to be displayed to the user. If so what is the message?

I tried to reproduce this bug and I see that the current UI doesn't allow an empty collection name. However, when I tap the keyboard's "Done" when trying to enter the empty name (or just whitespace), the keyboard closes, but the empty collection name field is still open. This is confusing. Can we disable the keyboard's "Done" button while the collection name is an empty string or just whitespace?

Ok, let me work on it

Comment 5

[happinessmncube]

I have been working on this issue and discovered that I can still reproduce it using these steps

1. Launch the FIrefox application.
2. Open a few tabsand from the tabs tray, tap the "Select tabs" button.
3. Select one/more tabs. Tap the save to collection icon.
4. Delete the "Collection 1" name and tap on OK button.
5. Check the name of the new collection.

Also, see this video https://www.loom.com/share/b31dbac82c274c798af16462d0df2834 I have pulled from main numerous times with the same results. Can you please take a look?

Comment 6

[Chris Peterson [:cpeterson]]

You're right. I can still reproduce this bug. I'm not sure what I was actually testing in my comment 2.

As I test again, I see there are two buttons we would need to disable or ignore when the new collection name is empty:

1. The "OK" button in the "Add new collection" dialog.
2. The "Done" button on the keyboard.

Comment 7

[happinessmncube]

Working on it.

This is the flow you were referring to in comment 2 https://www.loom.com/share/668967f4f56543688a688e5a6f2f8338. Not sure if it has a ticket already.

Comment 8

[happinessmncube]

Is it ok to use values supplied here https://github.com/mozilla-mobile/firefox-android/pull/1050#issuecomment-1453969942 for the OK button when it is inactive?

Comment 9

[Chris Peterson [:cpeterson]]

(In reply to happinessmncube from comment #8)

Is it ok to use values supplied here https://github.com/mozilla-mobile/firefox-android/pull/1050#issuecomment-1453969942 for the OK button when it is inactive?

I need to ask the UI designers to review your proposed solution. They have a long backlog of work, so that might take a couple weeks.

In the meantime, I recommend looking at Android good-first-bugs on "Codetribute" that don't require UI changes:

https://codetribute.mozilla.org/projects/fenix

Comment 10

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1812730 - Prevent collections with empty name from being created (#1356)

Comment 11

[Delia Pop (Android QA)]

This is still reproducible on the latest releases: Nightly 115.0a1, Firefox Beta 114.0b2, RC 113.0.
Tested with Xiaomi 12 Pro (Android 13).

Comment 12

[BMO Github Automation]

Authored by https://github.com/gitstart
https://github.com/mozilla-mobile/firefox-android/commit/5045d9cd87fe4280c32a4009254412fc563dc03a
[main] Bug 1812730 - Prevent collections with empty name from being created

Comment 13

[Lorand Janos]

Verified as fixed on the latest Nightly build (119.0a1 from 2023.08.29).
Collections cannot be created with empty name.
Device used: Google Pixel 7 (Android 14).
Marking the ticket as verified for 119.

Comment 14

[Chris Peterson [:cpeterson]]

happinessmncube, thanks for fixing this longstanding bug!