1812736 - No snackbar is displayed when adding new tab to a collection

Status: RESOLVED FIXED

(Fenix :: Collections, defect, P3)

Description

[Jeff Boek [:boek]]

From github: https://github.com/mozilla-mobile/fenix/issues/18702.

Steps to reproduce

1. Create a new collection (or use an existing one).
2. Open CNN.com.
3. Go to homescreen-collection-menu.
4. Tap on "Add tab" from the menu.
5. Tap on "Save" in order to add the tab to the collection.

Expected behavior

"Tab saved" snackbar is displayed.

Actual behavior

No snackbar is displayed.

Device information

Android device: all
Firefox for Android version: Latest Release 87.0.0-rc.1 and on the latest Nightly 210330 05:04 (GV89)

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[happinessmncube]

I would like to work on this issue

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to happinessmncube from comment #1)

I would like to work on this issue

Thanks for your help! I can assign this bug to you while you work on it.

Do you have a local build of Firefox Android running on a device or emulator?

https://firefox-source-docs.mozilla.org/contributing/build/building_mobile_firefox.html

If you have questions about building or running Firefox Android, drop by the #mobile-dev channel on Mozilla's Matrix server:

https://chat.mozilla.org/?#/room/#mobile-dev:mozilla.org

I see that we show the "Tab saved" snackbar (FenixSnackbar) when adding a tab to a collection while viewing that tab. The problem is just when adding tabs to a collection from the Firefox homepage.

https://github.com/mozilla-mobile/firefox-android/blob/a05ece3df1f60e7b10ab4b564b82f47b7ba8d0eb/fenix/app/src/main/java/org/mozilla/fenix/tabstray/ext/FenixSnackbar.kt#L24

Comment 3

[happinessmncube]

(In reply to Chris Peterson [:cpeterson] from comment #2)

(In reply to happinessmncube from comment #1)

I would like to work on this issue

Thanks for your help! I can assign this bug to you while you work on it.

Do you have a local build of Firefox Android running on a device or emulator?

https://firefox-source-docs.mozilla.org/contributing/build/building_mobile_firefox.html

If you have questions about building or running Firefox Android, drop by the #mobile-dev channel on Mozilla's Matrix server:

https://chat.mozilla.org/?#/room/#mobile-dev:mozilla.org

I see that we show the "Tab saved" snackbar (FenixSnackbar) when adding a tab to a collection while viewing that tab. The problem is just when adding tabs to a collection from the Firefox homepage.

https://github.com/mozilla-mobile/firefox-android/blob/a05ece3df1f60e7b10ab4b564b82f47b7ba8d0eb/fenix/app/src/main/java/org/mozilla/fenix/tabstray/ext/FenixSnackbar.kt#L24

I have a local build of Firefox Android running on a device and I have started working on the issue

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1812736 - Display snackbar when a new tab is added to a collection (#1277)

Comment 5

[BMO Github Automation]

Authored by https://github.com/gitstart
https://github.com/mozilla-mobile/firefox-android/commit/7a91ba643eedfb70d99c8cd2b0a4bed7c21a4497
[main] Bug 1812736 - Display snackbar when a new tab is added to a collection

Comment 6

[Lorand Janos]

This issue is no longer reproducible on the latest Nightly 113.0a1 (2023-03-19T16:07:14.285574) build.
When adding a page to the collection from the menu, the "Tab saved!" snackbar is displayed.
Device used: google Pixel 7 (Android 13).
Marking the issue as verified fixed for 113.

Comment 7

[Chris Peterson [:cpeterson]]

Thanks for fixing this bug! Your fix will ship in Firefox 113 on April 11.

If you're looking for more Android bugs, check out Codetribute for a list of other "good first bugs":

https://codetribute.mozilla.org/projects/fenix