1812859 - Incorrect tab number appears for a moment on swipe

Status: RESOLVED FIXED

(Fenix :: Tabs, defect)

Description

[Jeff Boek [:boek]]

From github: https://github.com/mozilla-mobile/fenix/issues/23860.

Steps to reproduce

1. Have at least 2 tabs open (Ideally at least 4).
2. Swipe between the tabs.
3. Observe the tab counter.

Expected behaviour

The tab counter shows the correct tab number.

Actual behaviour

The number shows 1 tab extra or 1 tab less for a moment.

Device name

Oppo Reno 6

Android version

Android 11

Firefox release type

Firefox Nightly

Firefox version

99.0a1

Device logs

No response

Additional information

https://user-images.githubusercontent.com/48829350/154974505-9b820d07-ec12-4f25-a269-0b0c389dab84.mp4

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Adina Petridean QA [:apetridean]]

Still reproducible with the latest Beta 112.0b2 build with Google Pixel 3 XL (Android 9).

Comment 2

[Adina Petridean QA [:apetridean]]

Still reproducible with the latest Beta 113.0b2 build with Xperia 10 (Android 12).

Comment 3

[jackyzy823]

I'm not very familiar with android view data binding mechanism.

However it looks like tabButton's count in tabPreview of ToolbarGestureHandler is not updated when start swiping.

(I'm not sure where tabButton's initial value from? and why it is not updated? )

But it could be fix by manually updating in preparePreview.

Comment 4

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1812859 - Update tabpreview's tab count when starting swipe (#2139)

Comment 5

[Matt Tighe [:matt-tighe]]

I am not deeply familiar with this area of the codebase, but it looks like the TabButton in TabPreview is separate from the TabButton that is displayed in a normal browsing session. The TabPreview that shows the count correctly has that count initialized and controlled by the TabCounterToolbarButton hosted in the BrowserFragment.

All that to say, I think the fix you've provided here is a suitable one that we can move forward with landing.

Comment 6

[BMO Github Automation]

Authored by https://github.com/jackyzy823
https://github.com/mozilla-mobile/firefox-android/commit/abac8d79ad435ae404b25258ed54bc951585e1e1
[main] Bug 1812859 - Update tabpreview's tab count when starting swipe

Comment 7

[Lorand Janos]

Verified as fixed on the latest Nightly 115.0a1 build from 05/25/2023.
The tab number remains the correct one on swipe.
Devices used: Oppo Find X5 (Android 13) and a Google Pixel 7 (Android 14)
Marking the ticket as verified for 115.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jackyzy823, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox114 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Matt Tighe [:matt-tighe]]

I don't believe this bug is worth uplifting to 114 and have edited the bug accordingly.

Comment 10

[miralobontiu]

Verified also on Fenix Beta 115.0b1 with Lenovo tablet M10 (Android 10).