1812898 - [Bug] Domain highlighting and alignment

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, enhancement)

Description

[Kevin Brosnan [Ex-Mozilla]]

From github: https://github.com/mozilla-mobile/fenix/issues/2501.

Steps to reproduce

Visit something with a subdomain, like https://bugzilla.mozilla.org.

Expected behavior

The base domain (eTLD+1) is highlighted (respectively the rest of the URL is displayed muted), as in Fennec or Desktop Firefox.
The base domain is right-aligned with the right edge of the URL bar, as in Fennec.

Actual behavior

Nothing. All the URL is displayed in the same font style, and long subdomains can push the base domain off the screen.

Compare also bug 1271998.

Device information

• Android device: Moto G4 Play, Android 6.0.1
• Fenix version: 1.0.9020, Build #11341807

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Michel Le Bihan]

Attachment: Bug 1812898 - Part 1: Add domain alignment in Android toolbar component. r=tthibaud

Comment 2

[Michel Le Bihan]

Attachment: Bug 1812898 - Part 2: Enable domain highlighting in Fenix toolbar. r=tthibaud

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34750a3f8473
Part 1: Add domain alignment in Android toolbar component. r=tthibaud,android-reviewers
https://hg.mozilla.org/integration/autoland/rev/0b308b152c3e
Part 2: Enable domain highlighting in Fenix toolbar. r=tthibaud,android-reviewers

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/34750a3f8473
https://hg.mozilla.org/mozilla-central/rev/0b308b152c3e

Comment 5

[Titouan Thibaud [:titouan]]

For reference, here is a link to Figma referencing the behavior that is implemented on this bug. It was approved by :topotropic on the Product side.

We acknowledge that there's a Compose rewrite of the Toolbar but the decision was taken to already accept implementing that on the current one, and the same behavior will be ported to the new one.

Comment 6

[Michel Le Bihan]

Release Note Request (optional, but appreciated)
[Why is this notable]: It changes the visible behavior of the toolbar. I believe that this is an important improvement as it make noticing phishing websites much easier.
[Affects Firefox for Android]: Yes and only affects Firefox for Android
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Comment 7

[Pascal Chevrel:pascalc]

Could you provide a wording for the note? thanks

Comment 8

[Michel Le Bihan]

I'm not sure how to explain this feature in a way that can be understood by non technical users.

Comment 9

[Pascal Chevrel:pascalc]

Titouan, could you provide a note please? Thanks

Comment 10

[Titouan Thibaud [:titouan]]

Release Note Request (optional, but appreciated)
[Why is this notable]: It changes the visible behavior of the toolbar. I believe that this is an important improvement as it make noticing phishing websites much easier.
[Affects Firefox for Android]: Yes and only affects Firefox for Android
[Suggested wording]: We enabled domain highlighting in the URL bar, making it clearer what is the actual website you are visiting.
[Links (documentation, blog post, etc)]:

Thanks a lot :Pascal!

Comment 11

[Pascal Chevrel:pascalc]

Note added to our Final Relnotes internal document as we don't produce pre-release notes for Android. Keeping the flag open until we add this note to our CMS in RC week, thanks.

Comment 12

[Mira Lobontiu (Android QA)]

Attachment: 1812898.jpg

Verified as fixed on the latest Firefox for Android 141.0a1 from 6/5 with the following devices:

• Samsung Galaxy Tab S9 Ultra (Android 15),
• Samsung Galaxy S24 (Android 15), and
• Xiaomi Mi8 Lite (Android 10).

The domain is bolded and in focus when the URL is longer - screenshots attached.
Tested on several pages: bugzilla.mozilla.org, wikipedia.org, theatlantic.com, cnn.com.