Closed Bug 1812936 Opened 2 years ago Closed 2 years ago

Avoid off-centering play and rewind buttons

Categories

(Toolkit :: Picture-in-Picture, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: asafko, Assigned: niklas)

References

Details

(Whiteboard: [fidefe-pip3])

Attachments

(4 files)

Attached image duration.png

02/09
We have decided to update the ticket with these acceptance criteria.

  1. We will remove duration at that window size when it starts to off-center play/pause buttons.
  2. We will adjust the grid so that for the min size player (200 px wide and smaller):
  • play and volume buttons will always remain centered,
  • the padding between the play and volume buttons (the only remaining buttons in the lower area of the PiP window) will be roughly 1/12 of the window width (e.g. 16 px padding for 192px width as in Figma).
Type: defect → enhancement
Assignee: nobody → nbaumgardner
Severity: -- → S3
Priority: -- → P2
Assignee: nbaumgardner → cmeador
Status: NEW → ASSIGNED
Whiteboard: [fidefe-pip3]
Duplicate of this bug: 1815139
Summary: Remove duration when it begins to off-center play and rewind buttons → Avoid off-centering play and rewind buttons
Attached image off-center min size.png
Attached image correct min size.png
Assignee: cmeador → nbaumgardner
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0639cb3b324 Keep playpause button centered in PiP. r=pip-reviewers,mhowell
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: