Closed Bug 1812970 Opened 2 years ago Closed 2 years ago

Avoid using Skia's deprecated clip ops

Categories

(Core :: Graphics: Canvas2D, task, P3)

task

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: lsalzman, Assigned: lsalzman)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Skia upstream has finally removed support for deprecated clip ops that can be used to replace the clipping stack entirely. We use these in a couple places that we can easily work around. Let's not use them so that we don't need to patch Skia itself...

Skia upstream removed deprecated clip ops that could be used to replace
the clipping stack and bypass clips. We shouldn't really need to do this
anymore, as we can work around it just using public APIs.

The only SkCanvas operation that allows us to bypass clipping is
writePixels, which still allows us to implement CopySurface/putImageData.

Other instances where we were using the replace op for DrawTargetWebgl
layering support can just be worked around by creating a separate
DrawTargetSkia pointing to the same pixel data, but on which no clipping
or transforms are applied so that we can freely do drawing operations
on it to the base layer pixel data regardless of any user-applied clipping.

Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f4f63f0138fe Avoid using Skia's deprecated clip ops. r=jrmuizel
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: