Avoid using Skia's deprecated clip ops
Categories
(Core :: Graphics: Canvas2D, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: lsalzman, Assigned: lsalzman)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Skia upstream has finally removed support for deprecated clip ops that can be used to replace the clipping stack entirely. We use these in a couple places that we can easily work around. Let's not use them so that we don't need to patch Skia itself...
Assignee | ||
Comment 1•2 years ago
|
||
Skia upstream removed deprecated clip ops that could be used to replace
the clipping stack and bypass clips. We shouldn't really need to do this
anymore, as we can work around it just using public APIs.
The only SkCanvas operation that allows us to bypass clipping is
writePixels, which still allows us to implement CopySurface/putImageData.
Other instances where we were using the replace op for DrawTargetWebgl
layering support can just be worked around by creating a separate
DrawTargetSkia pointing to the same pixel data, but on which no clipping
or transforms are applied so that we can freely do drawing operations
on it to the base layer pixel data regardless of any user-applied clipping.
Comment 3•2 years ago
|
||
bugherder |
Description
•