Closed Bug 1813002 Opened 2 years ago Closed 2 years ago

Mark all known boolean stack values in Baseline

Categories

(Core :: JavaScript Engine: JIT, enhancement, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: anba, Assigned: anba)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1813002: Mark boolean values in Baseline compilation. r=jandem!
48 bytes, text/x-phabricator-request
Details | Review

Marking known boolean stack values let's us avoid generating unnecessary ToBool ICs.

For example if (p in o) { ... } is currently generated a ToBool IC for the if statement, even though we know at compile time that the in expression always returns a boolean value.

This saves some unnecessary ToBool ICs for known boolean values.

Blocks: sm-jits
Severity: -- → N/A
Priority: -- → P1
Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/48e3f591f662 Mark boolean values in Baseline compilation. r=jandem

https://hg.mozilla.org/mozilla-central/rev/48e3f591f662

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox111: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: