1813016 - Remove unnecessary MDefinition::updateForReplacement() overrides

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1813016 - Part 1: Remove unnecessary MDefinition::updateForReplacement() overrides. r=iain!

MMul doesn't need to override updateForReplacement(), because MMul::congruentTo()
already ensures the mode and canBeNegativeZero fields match. See also bug 886243
and bug 940642.

MConstant doesn't need to override updateForReplacement(), because its congruentTo()
method ensures the result-type is equal. See also bug 1246658.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1813016 - Part 2: Change MDefinition::updateForReplacement() to return void. r=iain!

The return value isn't used anymore, so we can change this to return void.

Depends on D168061

Comment 3

[BugBot [:suhaib / :marco]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:anba, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[André Bargull [:anba]]

Attachment: Bug 1813016 - Part 3: Make updateForReplacement() a non-virtual method on MPhi. r=iain!

MPhi is the only instruction which implements updateForReplacement(), so let's
make it a non-virtual method.

Depends on D168062

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce035692dc40
Part 1: Remove unnecessary MDefinition::updateForReplacement() overrides. r=iain
https://hg.mozilla.org/integration/autoland/rev/200467114232
Part 2: Change MDefinition::updateForReplacement() to return void. r=iain
https://hg.mozilla.org/integration/autoland/rev/b0b4e87d37b1
Part 3: Make updateForReplacement() a non-virtual method on MPhi. r=iain

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ce035692dc40
https://hg.mozilla.org/mozilla-central/rev/200467114232
https://hg.mozilla.org/mozilla-central/rev/b0b4e87d37b1

Comment 7

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.