1813046 - Simplify scrollbar sizing code.

Status: RESOLVED FIXED

(Core :: Widget, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1813046 - Simplify scrollbar sizing code. r=mstange,spohl

This removes the capability of having differently-sized vertical and
horizontal scrollbars (which is only potentially used in windows, and in
practice almost-never used). For that case, we choose the larger of
vertical/horizontal scrollbar sizes.

This is in order to be able to realistically expose the scrollbar size
to CSS, see blocked bug.

We make RecomputeScrollbarParams the central place where each scrollbar
style decides its sizes, and make GetDPIRatioForScrollbarPart handle the
cocoa special-case of scaling to 1 or 2, but nothing else.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbd43288796e
Simplify scrollbar sizing code. r=spohl

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cbd43288796e

Comment 4

[Henry Wilkes (they/them) [:henry-x]]

@emilio I happened to see this change https://hg.mozilla.org/integration/autoland/rev/cbd43288796e#l3.16 but it seems like it might be a bug to have removed the differentiation between setting aSize.width and aSize.height depending on whether it is a vertical or horizontal scrollbar. I don't know this code well, so I might be missing something.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1813046 - follow-up: Remove dead chunk of code. r=spohl

All themes support scrollbar parts nowadays so this code is not needed.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Thanks! Turns out that is a buggy part of the change, but that chunk of code is dead nowadays.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb8b2fde280f
follow-up: Remove dead chunk of code. r=spohl

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bb8b2fde280f

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)