1813050 - Incorrect "Last modified" time when adding bookmarks from Library

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Ina Popescu]

Attachment: bookmarks_Library.png

Note

• Select to shown the column "Last modified" in Library(Views > Show columns > Last modified).

Found in

• Firefox 110.0b6

Affected versions

• Firefox 110.0b6
• Nightly 111.0a1
• Firefox 109.0
• Firefox 102.7.0esr

Tested platforms

• Affected platforms: Windows 10, macOS 13, Ubuntu 22.04
• Unaffected platforms: none

Steps to reproduce

1. Open Library (Ctrl+Shift+O) in Firefox
2. Select any bookmarks folder(Bookmarks Toolbar, Bookmarks Menu, Other Bookmarks) and right click to Add Bookmark
3. Fill in all the necessary details(name, url) and click the Add button

Expected result

• The correct time, when the bookmark was added, is shown in the "Last modified" column.

Actual result

• The wrong time(1/20/1970 11:13 AM) is shown in the "Last modified" column when adding new bookmarks directly from the Library.

Regression range

• I've managed to narrow down the regression range to:
  Last good : cc37b1400a58429d7d98556f6f64cd9fd2d73724
  First bad: 0c84f40112a50d2ac1a4a9f714191b60f0eaaec1
  Pushlog:https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=cc37b1400a58429d7d98556f6f64cd9fd2d73724&tochange=0c84f40112a50d2ac1a4a9f714191b60f0eaaec1
  In my opinion, the possible culprit for this issue is Bug 1678626.

Additional notes

• The issue can be reproduced also by adding new bookmarks using the Organize > Add Bookmark... option.
  The correct time is updated and shown in the "Last modified" column after navigating through the bookmarks folders from the left side menu.

Comment 1

[Release mgmt bot [:suhaib / :marco/ :calixte]]

:epopescu, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Release mgmt bot [:suhaib / :marco/ :calixte]]

:daisuke, since you are the author of the regressor, bug 1678626, could you take a look?

For more information, please visit auto_nag documentation.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Thank you very much for your reporting, Ina!
I also could reproduce this issue. Will fix it.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1813050: Pass lastModified as PRTime to OnItemUrlChanged .

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c415c9ceb78c
Pass lastModified as PRTime to OnItemUrlChanged . r=mak

Comment 6

[Serban Stanca]

https://hg.mozilla.org/mozilla-central/rev/c415c9ceb78c

Comment 7

[Ina Popescu]

Reproduced the issue on Nightly 111.0a1 (2023-02-05) on Windows 10 x64 by following the STR from Comment 1.
Verified as fixed on Nightly 111.0a1 (2023-02-07) on Windows 10 x64, macOS 13 and Ubuntu 22.04.