Closed
Bug 1813057
Opened 3 years ago
Closed 3 years ago
Replace setTimeouts with wait conditions in the `browser_protectionsUI_cookie_banner.js` test
Categories
(Firefox :: Protections UI, task, P1)
Firefox
Protections UI
Tracking
()
RESOLVED
DUPLICATE
of bug 1800670
People
(Reporter: jhirsch, Assigned: jhirsch)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-cookie-banner-v1])
This is a followup from https://phabricator.services.mozilla.com/D164241 (patch for bug 1800670). In that patch, a few very short setTimeout calls were introduced to paper over an issue where, after clicking the CBH toggle in the shield panel submenu, reopening the panel doesn't seem to work--the click isn't delivered to the shield toolbar button.
Rather than simply setTimeout and wait for the UI thread to do something, this followup bug asks that we figure out exactly what to wait for in the DOM or ChromeWindow state.
|
||
Comment 1•3 years ago
|
||
May I assign this to you Jared?
Severity: -- → N/A
Component: Privacy: Anti-Tracking → Protections UI
Flags: needinfo?(jhirsch)
Priority: -- → P1
Product: Core → Firefox
|
Assignee | |
Comment 2•3 years ago
|
||
Yup, I'll take it
Assignee: nobody → jhirsch
Flags: needinfo?(jhirsch)
Whiteboard: [fidefe-cookie-banner-v1]
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•3 years ago
|
||
Moving to v2 / 113 as we may not have time for it before 111 soft freeze
|
|
Assignee | |
Comment 4•3 years ago
|
||
This wound up getting done as part of fixing the test bustage for bug 1800670. Closing as a dupe.
You need to log in
before you can comment on or make changes to this bug.
Description
•