1813147 - wpt expect outbound-rtp stats to show up before packets have been sent

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect)

Description

[Byron Campen [:bwc]]

Multiple wpt require outbound-rtp stats to show up as soon as the PC is connected, but we do not start populating those stats until we have actually sent RTP. Additionally, there seems to be at least one case in wpt where it is testing for the presence of outbound-rtp stats when no packets have yet been sent:

https://searchfox.org/mozilla-central/rev/4d2b1f753871ce514f9dccfc5b1b5e867f499229/testing/web-platform/tests/webrtc-stats/rtp-stats-creation.html#47

I've looked at the spec, and it looks vague about this; I don't see any language specifying when, precisely, the outbound-rtp stats are expected to show up.

The delay here is causing intermittent PASS/FAIL on many of these test cases. We need to figure out what the spec's intent here is, modify the spec to explicitly state its intent, and then either fix our code, or fix the tests, depending on that intent.

Comment 1

[Byron Campen [:bwc]]

I think if we did this check later we could make this work: https://searchfox.org/mozilla-central/rev/4d2b1f753871ce514f9dccfc5b1b5e867f499229/dom/media/webrtc/jsapi/RTCRtpSender.cpp#254

And make sure we do this stuff regardless: https://searchfox.org/mozilla-central/rev/4d2b1f753871ce514f9dccfc5b1b5e867f499229/dom/media/webrtc/jsapi/RTCRtpSender.cpp#307-308

Might have to 0-init a few things too.

Comment 2

[Byron Campen [:bwc]]

Based on the following, it looks like the wpt are just wrong and need to be fixed:

https://github.com/w3c/webrtc-stats/issues/619
https://github.com/w3c/webrtc-stats/issues/667

Comment 3

[Byron Campen [:bwc]]

Proposed fix looks like this:

https://github.com/w3c/webrtc-stats/issues/619#issuecomment-1033028622

Comment 4

[Byron Campen [:bwc]]

Marking this as dependent on bug 1265827, because many of these tests fail in Firefox because of bug 1265827 before they ever get to outbound-rtp stats checking.

Comment 5

[Byron Campen [:bwc]]

Attachment: Bug 1813147: Fix these tests to wait until RTP flow before checking for outbound-rtp stats. r?jib

Also update ini files for remaining bugs.

Depends on D168143

Comment 6

[Byron Campen [:bwc]]

Try looks normal:

Baseline: https://treeherder.mozilla.org/jobs?repo=try&revision=6f92316db87cd6e887e7591e6a406c872f294c98
With patch: https://treeherder.mozilla.org/jobs?repo=try&revision=6434087620258b4205f61e9df2d2977cf61c19f2

Comment 7

[Byron Campen [:bwc]]

Attachment: WIP: Bug 1813147: (WIP) Fix these tests to wait until RTP flow before checking for outbound-rtp stats.

Depends on D168143

Comment 8

[Byron Campen [:bwc]]

Updated try push:

https://treeherder.mozilla.org/jobs?repo=try&revision=0890ea87dfdde359b6270c01b7d05b54af26021c

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5567371a9b3
Fix these tests to wait until RTP flow before checking for outbound-rtp stats. r=jib

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38506 for changes under testing/web-platform/tests

Comment 11

[Cristian Tuns]

Backed out for causing build bustages on PeerConnectionImpl.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]

mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f919e1da19a
Fix these tests to wait until RTP flow before checking for outbound-rtp stats. r=jib

Comment 14

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38528 for changes under testing/web-platform/tests

Comment 15

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in

Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836

Push with failures

Failure log #1 | TEST-UNEXPECTED-TIMEOUT | /webrtc/RTCPeerConnection-remote-track-mute.https.html | pc.close() on one side causes mute events on the other - Test timed out

Failure log #2 | TEST-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() audio and video validate all mandatory stats - assert_equals: Expect dictionary.transportId to be string expected "string" but got "undefined"

Failure log #3 | TEST-UNEXPECTED-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() on track associated with RTCRtpReceiver should return stats report containing inbound-rtp stats - assert_unreached: required stats <...>

Comment 16

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1c409f18d87
Fix these tests to wait until RTP flow before checking for outbound-rtp stats. r=jib

Comment 18

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38982 for changes under testing/web-platform/tests

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e1c409f18d87

Comment 20

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot