wpt expect outbound-rtp stats to show up before packets have been sent
Categories
(Core :: WebRTC: Signaling, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: bwc, Assigned: bwc)
References
Details
Attachments
(1 file, 1 obsolete file)
Multiple wpt require outbound-rtp stats to show up as soon as the PC is connected, but we do not start populating those stats until we have actually sent RTP. Additionally, there seems to be at least one case in wpt where it is testing for the presence of outbound-rtp stats when no packets have yet been sent:
I've looked at the spec, and it looks vague about this; I don't see any language specifying when, precisely, the outbound-rtp stats are expected to show up.
The delay here is causing intermittent PASS/FAIL on many of these test cases. We need to figure out what the spec's intent here is, modify the spec to explicitly state its intent, and then either fix our code, or fix the tests, depending on that intent.
Assignee | ||
Comment 1•1 year ago
|
||
I think if we did this check later we could make this work: https://searchfox.org/mozilla-central/rev/4d2b1f753871ce514f9dccfc5b1b5e867f499229/dom/media/webrtc/jsapi/RTCRtpSender.cpp#254
And make sure we do this stuff regardless: https://searchfox.org/mozilla-central/rev/4d2b1f753871ce514f9dccfc5b1b5e867f499229/dom/media/webrtc/jsapi/RTCRtpSender.cpp#307-308
Might have to 0-init a few things too.
Assignee | ||
Comment 2•1 year ago
|
||
Based on the following, it looks like the wpt are just wrong and need to be fixed:
https://github.com/w3c/webrtc-stats/issues/619
https://github.com/w3c/webrtc-stats/issues/667
Assignee | ||
Comment 3•1 year ago
|
||
Proposed fix looks like this:
https://github.com/w3c/webrtc-stats/issues/619#issuecomment-1033028622
Assignee | ||
Comment 4•1 year ago
|
||
Marking this as dependent on bug 1265827, because many of these tests fail in Firefox because of bug 1265827 before they ever get to outbound-rtp stats checking.
Assignee | ||
Comment 5•1 year ago
|
||
Also update ini files for remaining bugs.
Depends on D168143
Assignee | ||
Comment 6•1 year ago
|
||
Assignee | ||
Comment 7•1 year ago
|
||
Depends on D168143
Updated•1 year ago
|
Assignee | ||
Comment 8•1 year ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b5567371a9b3 Fix these tests to wait until RTP flow before checking for outbound-rtp stats. r=jib
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38506 for changes under testing/web-platform/tests
Comment 11•1 year ago
|
||
Backed out for causing build bustages on PeerConnectionImpl.cpp
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]
mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland
Upstream PR merged by moz-wptsync-bot
Comment 13•1 year ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4f919e1da19a Fix these tests to wait until RTP flow before checking for outbound-rtp stats. r=jib
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38528 for changes under testing/web-platform/tests
Comment 15•1 year ago
|
||
Backed out for causing wpt failures in
Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836
Upstream PR merged by moz-wptsync-bot
Comment 17•1 year ago
|
||
Pushed by bcampen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1c409f18d87 Fix these tests to wait until RTP flow before checking for outbound-rtp stats. r=jib
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38982 for changes under testing/web-platform/tests
Comment 19•1 year ago
|
||
bugherder |
Upstream PR merged by moz-wptsync-bot
Assignee | ||
Updated•1 year ago
|
Description
•