1813148 - Don't return already_AddRefed in nsPresContext::GetRootWidget.

Status: RESOLVED FIXED

(Core :: Layout, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1813148 - Don't return already_AddRefed in nsPresContext::GetRootWidget. r=dholbert,tnikkel

Let the caller addref it if needed.

I wrote this because I wanted to make some code dealing with it
thread-safe, but I ended up writing a less sketchy solution. However I
still think this is worth it.

It seems this only returns an already_AddRefed because before it used to
be an XPCOM-ish thing where the widget was returned as an out-param.

For now it doesn't change behavior but there are some callers that would
benefit from having less addref/release calls if they only need to read
simple stuff from the widget.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a045cec2973b
Don't return already_AddRefed  in nsPresContext::GetRootWidget. r=dholbert

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/a045cec2973b