[wpt-sync] Sync PR 38225 - Revert "VT: Require a documentElement for the transition to happen"
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox111 fixed)
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 38225 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/38225
Details from upstream follow.
Jonathan Lee <jonathanjlee@google.com> wrote:
Revert "VT: Require a documentElement for the transition to happen"
This reverts commit 39f8928063ad59b8e711e6c506988749067e3e3b.
Reason for revert:
Added test is failing on "Linux Tests" on a virtual suite: https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Tests/125697/overviewOriginal change's description:
VT: Require a documentElement for the transition to happen
This patch ensures that we don't start a transition if we don't
have a document element. This is because documentElement is the
originating element for the pseudo tree, so we need to have it
for the transition to happen.Note that if we want to support documents that don't have a
documentElement, then we need to figure out where to put the
pseudo elements.Fixed: 1410435
Change-Id: Ib380e87dba2986ace6a567f37ff2cfa5b30268ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4198955
Reviewed-by: Khushal Sagar \<khushalsagar@chromium.org>
Commit-Queue: Khushal Sagar \<khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1097990}Change-Id: I4951a882eb0ea758eff2d27f6ed531c9c303c96a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4199443
Commit-Queue: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Jonathan Lee \<jonathanjlee@google.com>
Owners-Override: Jonathan Lee \<jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1098039}
Assignee | ||
Comment 1•1 year ago
|
||
PR 38225 applied with additional changes from upstream: 30e0b260a99eb53f0de4a838b50c60406a42efc0
Assignee | ||
Comment 2•1 year ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=0dc4c2e9d72972d1f923b04708b51dce59e41d56
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d6f103d3a471 [wpt PR 38225] - Revert "VT: Require a documentElement for the transition to happen", a=testonly
Assignee | ||
Comment 4•1 year ago
|
||
Test result changes from PR not available.
Comment 5•1 year ago
|
||
bugherder |
Description
•