1813279 - all PSM xpcshell tests are being skipped

Status: RESOLVED FIXED

(Core :: Security: PSM, defect, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Bug 1805919 added the condition skip-if = os = 'win' && msix (note the single equals (presumably assignment? unclear why that's even allowed here) rather than double equals (equality test)) to PSM's xpcshell.ini file. The tests haven't been running since that landed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1805919

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: Bug 1813279 - re-enable tests that were disabled unconditionally by bug 1805919 r?jschanck

Bug 1805919 skipped tests that fail in MSIX builds, but inadvertantly
unconditionally skipped a number of tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/08b4b90bcebe
re-enable tests that were disabled unconditionally by bug 1805919 r=jschanck

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/08b4b90bcebe

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:keeler, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Pascal Chevrel:pascalc]

Dana, could you request uplift today so as that we have it in our last betas? Thanks!

Comment 7

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Comment on attachment 9314678 [details]
Bug 1813279 - re-enable tests that were disabled unconditionally by bug 1805919 r?jschanck

Beta/Release Uplift Approval Request

• User impact if declined: No tests = don't know if something's broken
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1813277
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is tests-only and doesn't change the behavior of the browser.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 8

[Pascal Chevrel:pascalc]

Comment on attachment 9314678 [details]
Bug 1813279 - re-enable tests that were disabled unconditionally by bug 1805919 r?jschanck

Approved for 110 beta 8, thanks.

Comment 9

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/9265df2afe30