all PSM xpcshell tests are being skipped
Categories
(Core :: Security: PSM, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox109 | --- | unaffected |
firefox110 | + | fixed |
firefox111 | + | fixed |
People
(Reporter: keeler, Assigned: keeler)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [psm-assigned])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Bug 1805919 added the condition skip-if = os = 'win' && msix
(note the single equals (presumably assignment? unclear why that's even allowed here) rather than double equals (equality test)) to PSM's xpcshell.ini file. The tests haven't been running since that landed.
Updated•1 year ago
|
Comment 1•1 year ago
|
||
Set release status flags based on info from the regressing bug 1805919
Assignee | ||
Comment 2•1 year ago
|
||
Bug 1805919 skipped tests that fail in MSIX builds, but inadvertantly
unconditionally skipped a number of tests.
Updated•1 year ago
|
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08b4b90bcebe re-enable tests that were disabled unconditionally by bug 1805919 r=jschanck
Comment 4•1 year ago
|
||
bugherder |
Comment 5•1 year ago
|
||
The patch landed in nightly and beta is affected.
:keeler, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox110
towontfix
.
For more information, please visit auto_nag documentation.
Comment 6•1 year ago
|
||
Dana, could you request uplift today so as that we have it in our last betas? Thanks!
Assignee | ||
Comment 7•1 year ago
|
||
Comment on attachment 9314678 [details]
Bug 1813279 - re-enable tests that were disabled unconditionally by bug 1805919 r?jschanck
Beta/Release Uplift Approval Request
- User impact if declined: No tests = don't know if something's broken
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1813277
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This is tests-only and doesn't change the behavior of the browser.
- String changes made/needed: none
- Is Android affected?: Yes
Comment 8•1 year ago
|
||
Comment on attachment 9314678 [details]
Bug 1813279 - re-enable tests that were disabled unconditionally by bug 1805919 r?jschanck
Approved for 110 beta 8, thanks.
Comment 9•1 year ago
|
||
bugherder uplift |
Description
•