1813282 - Add the residentKey field to AuthenticatorSelectionCriteria

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, enhancement, P3)

Description

[John Schanck [:jschanck]]

The AuthenticatorSelectionCriteria dictionary has a residentKey field in WebAuthn level 2.

https://www.w3.org/TR/webauthn-2/#dictionary-authenticatorSelection

Comment 1

[John Schanck [:jschanck]]

Attachment: Bug 1813282 - Add the residentKey field to AuthenticatorSelectionCriteria. r=keeler

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccc54cebee26
Add the residentKey field to AuthenticatorSelectionCriteria. r=keeler,webidl,smaug

Comment 3

[Serban Stanca [:SerbanS]]

Backed out for causing build bustages in AndroidWebAuthnTokenManager.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/webauthn/AndroidWebAuthnTokenManager.cpp:159:19: error: no member named 'requireResidentKey' in 'mozilla::dom::WebAuthnAuthenticatorSelection'

Comment 4

[Celeste Liu [:Coelacanthus]]

Failure may be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1554397 ？

Comment 5

[John Schanck [:jschanck]]

Thanks for the suggestion. This patch will help us move Bug 1554397 forward. But, as for the backout, I just failed to update AndroidWebAuthnTokenManager in my patch.

Comment 6

[Makoto Kato [:m_kato]]

Android implementation doesn't use requireResidentKey in Java side. So you can remove https://searchfox.org/mozilla-central/rev/31f5847a4494b3646edabbdd7ea39cb88509afe2/dom/webauthn/AndroidWebAuthnTokenManager.cpp#159-162 to land this. I will add resident key code by Bug 1554397 again.

Comment 7

[Norisz Fay [:noriszfay]]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/dcb12f0cfb12

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e97bbcd0eb44
Add the residentKey field to AuthenticatorSelectionCriteria. r=keeler,webidl,smaug

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/e97bbcd0eb44