1813335 - Audio playback becomes distorted after loop

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Toshihiro Yamada]

On some sites, audio from <audio> tag with loop attribute becomes distorted after loop.
The problem happens only in nightly.

STR:

1. Open http://html5.cyberlab.info/elements/embedded/audio-loop.html
2. Play audio and wait loop.

Expected Results:
Audio plays normally after loop.

Actual Results:
Audio becomes distorted after loop.

I didn't test (because autoland build removed by antivirus soft...), but the problem appeared from 1/27 nightly. So, probably, regression from Bug 1703812?

Audio section in about:support
メディア

音声バックエンド: wasapi
最大チャンネル数: 2
優先サンプルレート: 48000
往復遅延時間 (標準偏差): 55.78ms (2.89)
コーデックサポート情報: H264 SW H264 HW VP8 SW VP8 HW VP9 SW VP9 HW AV1 SW Theora SW AAC SW FLAC SW MP3 SW Opus SW Vorbis SW Wave SW
出力デバイス
デバイス名: グループ
VG259 (NVIDIA High Definition Audio): HDAUDIO\FUNC_01&VEN_10DE&DEV_009E&SUBSYS_19DA5630&REV_1001\5&37805ffd&0&0001
スピーカー (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0897&SUBSYS_18494897&REV_1004\4&2349bde5&0&0001
入力デバイス
デバイス名: グループ
マイク (HyperX SoloCast): USB\VID_03F0&PID_078B&MI_00\6&2da0b062&0&0000
ライン入力 (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0897&SUBSYS_18494897&REV_1004\4&2349bde5&0&0001
マイク (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0897&SUBSYS_18494897&REV_1004\4&2349bde5&0&0001
ステレオ ミキサー (Realtek High Definition Audio): HDAUDIO\FUNC_01&VEN_10EC&DEV_0897&SUBSYS_18494897&REV_1004\4&2349bde5&0&0001
メディア機能
データベースを列挙

Comment 1

[Alice0775 White]

I can reproduce the issue on Windows10 and Ubuntu20.04.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a544e102fa0e1c47af2f165f2fdedb715a0ac458&tochange=ed77ecb589df8e31093b559aad1255f28eb038a8

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:padenot, since you are the author of the regressor, bug 1703812, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1813335 - Reset the EOS flag when decoding mp3 in a loop. r?alwu

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1813335 - Rework encoder delay and padding trimming when decoding audio with ffmpeg. r?alwu

Depends on D168275

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1813335 - Test seamless looping of compressed audio files. r?alwu

Depends on D168276

Comment 6

[val.zapod.vz]

Yep, happens on android too.

Comment 7

[Paul Adenot (:padenot)]

Attachment: Bug 1813335 - Add logging statements on flush and shutdown in FFmpegDataDecoder. r?alwu

Depends on D168291

Comment 8

[Paul Adenot (:padenot)]

Attachment: Bug 1813335 - Rework encoder delay and padding trimming when decoding audio with AudioToolkit. r?alwu

Depends on D168277

Comment 10

[James Teh [:Jamie]]

Note that this also affects short sounds that aren't necessarily played in a loop, but are repeated later; e.g. Slack notification sounds.

Comment 11

[Donal Meehan [:dmeehan]]

:padenot this is the final week of 111 nightly, 111 goes to beta next week.
Do you plan on making changes and landing these patches in central this week?
Otherwise, we could consider backing out Bug 1703812 from 111 beta?

Comment 12

[Paul Adenot (:padenot)]

Yes, let's backout bug 1703812, there's too many issues and this needs more work that I don't want to rush. I'm pushing to try now.

Comment 13

[Donal Meehan [:dmeehan]]

Setting 111 to fixed, bug 1703812 the regressor was backed out.

Comment 14

[Paul Adenot (:padenot)]

I'll do the remaining work there.

Comment 15

[Phabricator Automation]

Comment on attachment 9315137 [details]
Bug 1813335 - Add logging statements on flush and shutdown in FFmpegDataDecoder. r?alwu

Revision D168405 was moved to bug 1703812. Setting attachment 9315137 [details] to obsolete.

Comment 16

[Phabricator Automation]

Comment on attachment 9314898 [details]
Bug 1813335 - Test seamless looping of compressed audio files. r?alwu

Revision D168277 was moved to bug 1703812. Setting attachment 9314898 [details] to obsolete.

Comment 17

[Phabricator Automation]

Comment on attachment 9314897 [details]
Bug 1813335 - Rework encoder delay and padding trimming when decoding audio with ffmpeg. r?alwu

Revision D168276 was moved to bug 1703812. Setting attachment 9314897 [details] to obsolete.

Comment 18

[Phabricator Automation]

Comment on attachment 9315190 [details]
Bug 1813335 - Rework encoder delay and padding trimming when decoding audio with AudioToolkit. r?alwu

Revision D168439 was moved to bug 1703812. Setting attachment 9315190 [details] to obsolete.