1813403 - [XFCE] Firefox now raises on click

Status: RESOLVED INVALID

(Core :: Widget: Gtk, defect, P3)

Description

[Justin Tracey]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

The latest Nightly, with the new UI, has changed how it interacts with "Raise on focus" or "Raise on click" settings. When using a window manager configured to not raise the focused window to the top (e.g., using XFCE's Window Manager->Focus settings), the behavior of clicking within a Firefox window has changed.

Actual results:

Even with "Raise on focus" and "Raise on click" disabled, Firefox raises itself above all other windows when clicked anywhere.

Expected results:

Firefox should respect the setting of the window manager, and maintain its z coordinate when settings indicate it should do so. This is how Firefox worked until recently.

Comment 1

[Justin Tracey]

This should possibly be marked as a regression of #236299.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

I wonder if Bug 1812289 is the cause here. Can you try nightly before it? You can download directly from https://archive.mozilla.org/pub/firefox/nightly/2023/01/
Thanks.

Comment 4

[Justin Tracey]

Yep, confirmed that 2023-01-25-09-42-00-mozilla-central does not have the bug but 2023-01-25-21-52-01-mozilla-central does.

Comment 5

[Justin Tracey]

I can also confirm setting browser.tabs.inTitlebar = 0 fixes it.

Comment 6

[Justin Tracey]

Should this be marked as a regression for Bug 1812289?

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1812289, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

This seems to be the expected behavior for all CSD applications. Happens in Chromium by default, and in Gedit as well.

Given the option is not default and we provide the option to show system titlebar, it's not fixable on our side.

I traced this back to xfwm4's source code:

// src/events.c
if ((screen_info->params->raise_on_click) ||
    !FLAG_TEST (c->xfwm_flags, XFWM_FLAG_HAS_BORDER))
{
    clientClearDelayedRaise ();
    clientRaise (c, None);
}

So, basically, if "raise on click" is enabled, or the window has no border (so CSD window), raise.

XFCE dev saying:

note this option cannot work with client side decorations (most gtk3 clients nowadays) simply because, well, the client draws its decorations instead of xfwm4 so I reckon we'd rather remove that option, it's become unreliable (as depending on the client).

So anyways, given all that, I think this is WONTFIX / INVALID.