1813452 - Figure out what to do with AboutLibrariesFragmentTest with oss-licenses-plugin 0.10.5+

Status: RESOLVED FIXED

(Firefox for Android :: General, task)

Description

[Chris Peterson [:cpeterson]]

From github: https://github.com/mozilla-mobile/fenix/issues/27287.

I was recently looking at updating various Gradle dependencies to their latest releases and attempted to bump oss-licenses-plugin from the current 0.10.4 version to 0.10.5, but hit failures in AboutLibrariesFragmentTest.
java.lang.IllegalArgumentException: No item found containing text "org.mozilla.geckoview:geckoview"

I launched the APK locally to check with the Licenses screen looked like and the reason for the failure became apparent:

This appears to be an intentional change made by upstream commit https://github.com/google/play-services-plugins/commit/138a15dc9209192c6a9397b341b0ef7ddc346af4

This is problematic for us because we only run these unit tests on debug builds, so we'd be left with no test coverage if we skipped the failing test and took the newer release. There isn't a pressing need to do so at this time anyway, but we probably do want to give it a think before we end up in a situation where there is a more urgent need to update and we're blocked on this.

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Capturing my chat with Olivia about this today, we either need to look into running the unit tests on release builds as well as debug so we can skip the test on debug or try porting it to another test suite that already runs on release builds.

Maybe UI tests could be a decent candidate to port it to? My guess is that option will be the more straight-forward option of the two.

FWIW, we should probably also look into ensuring that Focus gets a similar test added since this feels like pretty important functionality we don't want to accidentally break in any product we ship.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Oana, is this something your team would have cycles to look into?

Comment 3

[Oana Horvath [:ohorvath - out of office]]

Yes, I have it on my todo list.

Comment 4

[Oana Horvath [:ohorvath - out of office]]

Attachment: Bug 1813452 - Add libraries fragment UI test

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65fad9d1d019
Add libraries fragment UI test r=ohall,RyanVM,aaronmt

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/65fad9d1d019