If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

NS_NewTextNode() should "return" an nsITextContent and not an nsIContent

RESOLVED FIXED in mozilla1.3alpha

Status

()

Core
DOM
RESOLVED FIXED
15 years ago
15 years ago

People

(Reporter: jst, Assigned: jst)

Tracking

({perf})

Trunk
mozilla1.3alpha
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [HAVE FIX])

Attachments

(2 attachments)

(Assignee)

Description

15 years ago
Currently NS_NewTextNode() gives you back a nsIContent pointer which means that
everyone that wants to set some text data in the new text node must QI it to
nsITextContent or nsIDOMTextNode. This is silly, patch coming up.
(Assignee)

Comment 1

15 years ago
Created attachment 107075 [details] [diff] [review]
Change NS_NewTextNode() to "return" nsITextContent
(Assignee)

Comment 2

15 years ago
Created attachment 107076 [details] [diff] [review]
diff -w of the above
(Assignee)

Comment 3

15 years ago
Comment on attachment 107076 [details] [diff] [review]
diff -w of the above

Note that this attachment is diff -w, look at the first attachment for the real
change.
Attachment #107076 - Flags: superreview?(bzbarsky)
Attachment #107076 - Flags: review?(caillon)
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla1.3alpha
Attachment #107076 - Flags: superreview?(bzbarsky) → superreview+
Attachment #107076 - Flags: review?(caillon) → review+
(Assignee)

Comment 4

15 years ago
Fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.