Save reference to container in FeatureCallout
Categories
(Firefox :: Messaging System, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: aminomancer, Assigned: aminomancer)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The container ID for feature callouts is root, which is a pretty generic ID (we might want to change that, now that feature callouts can exist in the chrome). We're also searching the DOM for this container several times in the lifecycle of a callout. That is largely a vestige of the old architecture of feature callout, from before it was a true module. Now that FeatureCallout is a class, it can hold a reference to its container. Long term I think it would be nice to turn FeatureCallout into a custom element, so that we can reference the DOM node with this instead of this._container for example. But for now we should just add a _container property and replace the searches with references.
|
||
Comment 1•1 year ago
|
||
Refactoring here will benefit chrome usage of feature callout
|
Assignee | |
Comment 2•1 year ago
|
||
|
||
Updated•1 year ago
|
Pushed by shughes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/315e334a88c5 Encapsulate aboutwelcome container and make its ID more unique. r=omc-reviewers,fxview-reviewers,sfoster,jprickett
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
Description
•