1813809 - Implement safeguard for Feature Callout pref getter function

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Jason Prickett]

When a feature callout pref is changed to a value that can't safely be JSON.parsed, it causes an error that can freeze a tab if the callout is used in chrome. The custom function in the featureTourProgress pref getter should be bolstered to implement a safeguard to prevent this error from freezing a tab in this scenario.

Comment 1

[Jason Prickett]

To manually reproduce this issue, you can try the following steps:

1. update the browser.pdfjs.feature-tour to {"screen":"FEATURE_CALLOUT_1_A","complete":false}
2. In a new tab, navigate to any pdf file and observe the feature callout appear
3. Tab back over to about:config and update that pref to be something that is not parsable JSON (so a string or basically anything that's not an object should do) and try to go back to the PDF tab. The active tab will not change to the PDF tab.

Comment 2

[hanna A]

Attachment: Bug 1813809 - Implement safeguard for Feature Callout pref getter function r=#omc-reviewers

Comment 3

[hanna A]

Attachment: Bug 1813809 - Implement safeguard for Feature Callout pref getter function r=#omc-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57b39eab6460
Implement safeguard for Feature Callout pref getter function r=omc-reviewers,aminomancer

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/57b39eab6460