1813877 - [a11y] Page name/URL isn't announced when swipe of the navbar is performed (switching tabs)

Status: VERIFIED FIXED

(Fenix :: Toolbar, defect, P2)

Description

[Gabriel [:gl] (ΦωΦ)]

From github: https://github.com/mozilla-mobile/fenix/issues/15631.

Steps to reproduce

1. Enable TalkBack.
2. Open 2-3 pages.
3. Using 2 fingers, swipe the nav bar left and right to switch tabs.

Expected behavior

Page name + "loading" is announced.

Actual behavior

"Loading" is announced, without the name (URL) of the page.

Device information

• Android device: LG G7 FIT (Android 8)
• Fenix version: Nightly 10/2

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[Joe M [:jmahon]]

(replying to a thread from Github)

Lorand, you had mentioned this was intermittently reproducible in the past. Does it always happen for the same web pages? Approximately how common is this bug?

Comment 2

[Lorand Janos]

After the first page is focused either the page itself, or the address bar, the page name is announced, "loading" is only announced if it's refreshed or newly opened page (accessing a page after opening it in new tab and swiping to it from the address bar). For these pages only the "loading" part is announced and nothing else.
After that first page from which the swiping starts, I didn't get to a page that had its name announced, only if tapped on address bar again, or the page itself. (On the video I tapped a page by accident. That was announced.)

Comment 3

[Lorand Janos]

Attachment: az_recorder_20230207_171255_edited.mp4

Comment 4

[Joe M [:jmahon]]

Oof, yeah, this is definitely at least an S2, I was able to repro this quite easily & it's a common use case. Thanks for the additional detail. Adding to Kanban board to pick up soon.

Note to engineering for what to try to accomplish with this:

• When swiping between tabs, the URL should be automatically dictated by TalkBack (it's already shown to have the green highlight, so I'm not sure why it wouldn't be dictated)
• Nice-to-have (though, don't spend too much effort making this happen - I think we need to review TalkBack elegance across the board): when you load a new page (after typing & entering a URL), TalkBack seems to highlight either the "site information" (🔒) button or the "tabs" button. It would be nice if it instead started with the URL, or perhaps even better, the contents of the page itself.

Comment 5

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1813877 - Announce page title with talkback when swiping on navbar (#790)

Comment 6

[Lorand Janos]

Verified as fixed on the latest Nightly 112.0a1 (2023-02-19T16:08:33.109137) build.
The pages names are announced.
Device used: Google Pixel 7 (Android 13).
Marking this ticket as verified.

Comment 7

[Chris Peterson [:cpeterson]]

Vlad, do you think your navbar fix is safe to uplift to Beta 111?

Comment 8

[BMO Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1813877 - Announce page title with talkback when swiping on navbar (backport #790) (#981)

Comment 9

[Vlad Dreghici [:vdreghici]]

Comment on attachment 9319661 [details] [review]
[mozilla-mobile/firefox-android] Bug 1813877 - Announce page title with talkback when swiping on navbar (backport #790) (#981)

Beta/Release Uplift Approval Request

• User impact if declined: Accessibility service will not announce the description of tab swiped to using gestures on navbar.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Enable TalkBack.
  Open 2-3 pages.
  Using 2 fingers, swipe the nav bar left and right to switch tabs.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small modification improving a11y, verified by QA.
• String changes made/needed: no
• Is Android affected?: Yes

Comment 10

[Donal Meehan [:dmeehan]]

Comment on attachment 9319661 [details] [review]
[mozilla-mobile/firefox-android] Bug 1813877 - Announce page title with talkback when swiping on navbar (backport #790) (#981)

Approved for Fenix 111.0b6

Comment 11

[Vlad Dreghici [:vdreghici]]

A regression has been discovered regarding this patch here: https://bugzilla.mozilla.org/show_bug.cgi?id=1817611 . It has been fixed here: https://github.com/mozilla-mobile/firefox-android/pull/1004 . This will require an uplift after it has been merged and checked by QA.

Comment 12

[Lorand Janos]

Verified as fixed on the latest Beta 111.0b6 build.
The described issue is no longer reproducible on the mentioned build.
Devices used to verify:

• Google Pixel 7 (Android 13).
• Google Pixel 6 ( Android 13).
• Samsung Galaxy Tab A7 (Android 12).
• OnePlus 5 A5000 (Android 10).
• OnePlus A3000 (Android 6).

Marking the ticket as verified for 111 as well.