Closed Bug 1813967 Opened 4 months ago Closed 4 months ago

AttachmentMenuController is leaked into the top window

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Version:
Thunderbird 111
Type:
defect

Tracking

(thunderbird_esr102 unaffected)

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
thunderbird_esr102 --- unaffected

People

(Reporter: darktrojan, Assigned: darktrojan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1813967 - Stop adding AttachmentMenuController and SecurityController to the top window. r=#thunderbird-reviewers
48 bytes, text/x-phabricator-request
Details | Review

I've been upgrading the test that checks windows are properly cleaned up after closing (browser_detachedWindows.js) and discovered that an AttachmentMenuController is added to the top window's command controller for every message tab that opens. It's never removed when the tab closes, and it doesn't work for the intended purpose anyway.

I'm going to use this bug to clean up it and some associated messes I found along the way.

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/347aa08779ec
Stop adding AttachmentMenuController and SecurityController to the top window. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.