1813980 - [CTW] ApplyCrossDocOffset checks Parent before IsDoc

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[James Teh [:Jamie]]

RemoteAccessibleBase::ApplyCrossDocOffset checks parent, returning early if it's null. It then checks IsDoc, returning early if that's false. We should flip that around, since IsDoc is cheaper given that Parent currently requires a hash lookup (bug 1798620).

This is a micro-optimisation, but I wonder whether it might matter, particularly for hit testing where we call Bounds a lot.

Comment 1

[James Teh [:Jamie]]

Attachment: Bug 1813980: Check IsDoc before Parent in RemoteAccessibleBase::ApplyCrossDocOffset.

We call this function on every ancestor when calculating bounds.
RemoteParent() currently requires a hash lookup, so it's more efficient to early return for !IsDoc() first.
This is a micro-optimisation, but it might have some impact given that we call this on every ancestor, especially when hit testing, where we call Bounds() a lot.

As a bit of drive-by cleanup, use RemoteParent() rather than calling Parent() and IsRemote/AsRemote().

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd0fdd1daa69
Check IsDoc before Parent in RemoteAccessibleBase::ApplyCrossDocOffset. r=morgan

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/dd0fdd1daa69