Closed
Bug 1813995
Opened 1 year ago
Closed 1 year ago
Nullify `conn` for all Actors on destruction
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox111 fixed)
RESOLVED
FIXED
111 Branch
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Actor and Pool classes are both setting conn attribute on instantiation, but never clear it on destruction. If we happen to leak any of these instances, this will hold DevToolsServerConnection in memory as well.
It would be nice to always clear this reference on destroy.
|
Assignee | |
Comment 1•1 year ago
|
||
A few classes weren't passing the conn object to Actor's constructor
and instead manually defining it.
Some others were having a duplicated _conn alias.
|
||
Updated•1 year ago
|
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00d324e0aacd [devtools] Nullify conn for all Actors on destruction. r=jdescottes,devtools-reviewers
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox111:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•