Closed Bug 1814002 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 38279 - Fix DCHECK when appending to a Typed CSSOM property with var().

Categories

(Core :: DOM: CSS Object Model, task, P4)

Product:
Core
Component:
DOM: CSS Object Model
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38279 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38279
Details from upstream follow.

Steinar H. Gunderson <sesse@chromium.org> wrote:

Fix DCHECK when appending to a Typed CSSOM property with var().

The previous fix was incomplete; this fixes another case (when trying
to set a shorthand on top of a longhand).

Fixed: 1407955
Change-Id: I5448aef7416ae0a28626e367861409446cb21c5c

Reviewed-on: https://chromium-review.googlesource.com/4206433
WPT-Export-Revision: 1867081fe6c2a783ede9c79eea682f76f275e680

PR 38279 applied with additional changes from upstream: cba6256810f44f786cf14b60b44452ff2613f18f
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 14 subtests

Status Summary

Firefox

ERROR: 1

Chrome

CRASH: 1

Safari

OK : 1
PASS : 13
FAIL : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-typed-om/the-stylepropertymap/declared/append.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: CRASH, Safari: OK)

Tests Disabled in Gecko Infrastructure

  • /css/css-typed-om/the-stylepropertymap/declared/append.tentative.html [wpt.fyi]: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: CRASH, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8fa44b9ff0b2 [wpt PR 38279] - Fix DCHECK when appending to a Typed CSSOM property with var()., a=testonly

https://hg.mozilla.org/mozilla-central/rev/8fa44b9ff0b2

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.