1814047 - Text from button is not visible on print preview nor on saved pdf.

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[Monica Chiorean]

Attachment: Screenshot

Found in

• 110.0b7 beta (20230129190147)

Affected versions

• 110.0b7 (20230129190147)
• 111.0a1 (20230130095434)

Tested platforms

• Affected platforms: Win7, Win10
• Unaffected platforms: will update

Steps to reproduce

1. Open the following link (https://www.washingtonpost.com/gdpr-consent/?next_url=https%3a%2f%2fwww.washingtonpost.com%2f).
2. Select Ctrl+P to print preview the page.
3. Select to Save to PDF.

Expected result

• Text from the button ‘Browse now’ should be visible on print preview.

Actual result

• On print preview the text is not visible only a black button is displayed (see attached screenshot), text is not visible on PDF file either.

Regression range

• Will look for one.

Additional notes

• Issue does not reproduce on Chrome.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Trivial test-case.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1814047 - Make buttons not ignore the "print backgrounds" setting. r=jfkthame,dholbert,#layout

We were ignoring print backgrounds, but still darkening colors, which
obviously breaks.

I tracked this down to bug 191574 /
https://searchfox.org/mozilla-central/commit/0757c0a5b18b646554969a67eedf2bcb0ad41b63

Make sure all caller have to pass in the "ignore 'print backgrounds'
Make block/inline not ignore that pref

Which was just preserving behavior. So this seems all rather accidental.

Implement backgrounds for page / page sequence frame using
print-color-adjust, and remove the virtual method.

The XUL box removal stuff seems harmless. The only XUL boxes we have
around in content are scrollbars, and we don't have scrollbars when
printing.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1814047 - Add support for testing print-background options on reftests. r=jfkthame

Depends on D168382

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1814047 - Add a test for this bug. r=jfkthame

Depends on D168491

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1721492ffd0c
Make buttons not ignore the "print backgrounds" setting. r=jfkthame,layout-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2e0bc9c8683
Add support for testing print-background options on reftests. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/e26b05e5e4be
Add a test for this bug. r=jfkthame

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/1721492ffd0c

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Very long-standing bug, can probably ride the trains.

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e2e0bc9c8683
https://hg.mozilla.org/mozilla-central/rev/e26b05e5e4be

Comment 11

[Monica Chiorean]

Verified as fixed on Win10, Mac 10.13, Ubuntu 20.04 using FF build 111.0a1(20230202091542).