1814057 - Text not correctly displayed on print preview nor on saved pdf.

Status: RESOLVED DUPLICATE of bug 1744363

(Core :: Layout: Flexbox, defect)

Description

[Monica Chiorean]

Attachment: Screenshot

Found in

• 110.0b7 beta (20230129190147)

Affected versions

• 110.0b7 beta (20230129190147)
• 111.0a1 (20230130095434)

Tested platforms

• Affected platforms: Win7, Win10
• Unaffected platforms: will update

Steps to reproduce

1. Open the following link (http://salesreceiptstore.com/fake-receipt-templates/).
2. Select Ctrl+P to print preview the page.
3. Select to Save the PDF.

Expected result

• Text should be correctly displayed on print preview.

Actual result

• Text overlaps on print preview and on pdf (see attached screenshot).

Regression range

• Will look for one.

Additional notes

• Issue does not reproduce on Chrome.

Comment 1

[Alice0775 White]

Good build: Layout seems wrong(Boxes are side by side.), but texts do not overlap.
Bad build: Texts overlap.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bbc6744b3ca2f9b902c30bbb8c99965563421c5b&tochange=18dbcec715c7f176ef13c30579efd5603148c4de

Triggered by Bug 1414600.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1414600

:emilio, since you are the author of the regressor, bug 1414600, could you take a look?

For more information, please visit auto_nag documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Yeah, this is a print issue, but my change is correct, not really a regression. It just so happens that without it we don't hit the relevant media query breakpoints.

This is a flex fragmentation issue. I don't see this if I change:

.panel-grid.panel-has-style > .panel-row-style, .panel-grid.panel-no-style

From display: flex to display: block. I'll try to reduce it a bit, but moving to the right component for now.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1414600

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Emilio is right. This is a flex fragmentation issue.

The first image (the picture with five "LOGO" receipts) happens to be at the end of first page, but there is insufficient space for it, so we will move it to the top of the second page. However, this can cause the flex item ancestor to become taller, but our current flex fragmentation code is not capable of adjusting the position of other items. The evidence is that if you shrink the printing scale to make the first image fit in the first page (on my system scale <= 90% will do), there is no content overlap.

Comment 6

[Alice0775 White]

Clear Regressed by.

Comment 7

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

The testcase in comment 0 looks good in print-preview in Nightly 122.0a1 (2023-12-06) after bug 1744363 is fixed. There is no content overlapping.