1814063 - Remove and cancel buttons aren't visible in confirmation window to delete cookies and website data

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect)

Description

[bbhtt]

Attachment: Working dialogue

Sorry for filing this so late but I observed the bug last year while using Nightly and it seems that it still happens on current Nightly 111.0a1 (2023-01-30).

The remove and cancel buttons aren't visible in the confirmation window to delete cookies and website data. I have to use Tab and press enter based on the calculated position/selection.

Also the dialogue appears with the wrong geometry (too much height for my screen size - 1366*768)

See the screenshots.

STR:

1. Have enough cookies at least 4-6
2. Remove all except 1
3. The confirmation dialogue appears but the buttons aren't visible

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:bbhtt.zn0i8, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[bbhtt]

Attachment: Broken dialoge 1

Comment 3

[bbhtt]

Attachment: Broken dialoge 2

Comment 4

[bbhtt]

Attachment: aboutsupport of current Nightly

Comment 5

[bbhtt]

System info:

gtk3 3.24.36
gtk4 4.9.2
gnome-shell 43.2 wayland with MOZ_ENABLE_WAYLAND=1

I bisected this down to:

$ mozregression --good 107.0 --bad 108.0

https://hg.mozilla.org/releases/mozilla-release/pushloghtml?fromchange=a9a9c8c68badf2c5ce288111cfa036e332617e63&tochange=aa449cfc7f6333480f11b1a2e6dc33cecb90026a

$ mozregression --bad 2022-12-05 --good 2022-11-28

30:33.38 INFO: No more integration revisions, bisection finished.
30:33.38 INFO: Last good revision: 985e74a5aa9969b2b6d24beced773dfbb2501d46
30:33.38 INFO: First bad revision: 08c1cafc9cf0969546d0e9bd3e6d2331b6db30f6
30:33.38 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=985e74a5aa9969b2b6d24beced773dfbb2501d46&tochange=0

So https://bugzilla.mozilla.org/show_bug.cgi?id=1802706 seems responsible

Comment 6

[bbhtt]

• the push log is https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=985e74a5aa9969b2b6d24beced773dfbb2501d46&tochange=08c1cafc9cf0969546d0e9bd3e6d2331b6db30f6

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1802706, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Does this happen on a clean profile? That's rather odd. What's your screen size / resolution / etc?

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1814063 - Minor tweak to site data settings dialog styles. r=mconley,Gijs

I can repro the issue with a larger size in the CSS (though I couldn't
find a screen size+resolution combo that caused this "naturally").

That said, 36em seems quite a lot, so reduce it to 20em which is what
the other dialogs use.

Also, use max-height rather than height so that the box is smaller for
smaller lists. We know this list has at least two elements so it should
look fine.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1802706

Comment 11

[bbhtt]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #8)

Does this happen on a clean profile? That's rather odd. What's your screen size / resolution / etc?

Yea it does, I've attached a screenrecord. The screen size is 15.6" (39.62 cm) and the resolution is 1366x768 px

Comment 12

[bbhtt]

Attachment: screenrecord

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d49d18466b7
Minor tweak to site data settings dialog styles. r=mconley,settings-reviewers

Comment 14

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/1d49d18466b7

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 16

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9315125 [details]
Bug 1814063 - Minor tweak to site data settings dialog styles. r=mconley,Gijs

Beta/Release Uplift Approval Request

• User impact if declined: comment 0 in some resolutions.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0, see resolution needed further down.
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial CSS fix.
• String changes made/needed: none
• Is Android affected?: No

Comment 17

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9315125 [details]
Bug 1814063 - Minor tweak to site data settings dialog styles. r=mconley,Gijs

Approved for our last 110 beta, thanks.

Comment 18

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/739d0fa29146

Comment 19

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 111.0a1 (2023.01.30) on Ubuntu 22.04 x64, with the screen resolution at 1368 x 768 and the scale at 125%.
I can confirm this issue is fixed, I verified using Firefox 111.0a1 (2023.02.01) latest nightly build, on Ubuntu 22.04 x64.

Comment 20

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 110.0b9 build, on Ubuntu 22.04 x64, the remove and cancel button are visible.