1814085 - [wpt-sync] Sync PR 38285 - Fix for repeated table sections inside clipped container.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38285 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38285
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Fix for repeated table sections inside clipped container.

When we reach the block-end of a container with clipped overflow, we
re-lay out the last fragment with block fragmentation forced off. That's
RelayoutWithoutFragmentation() in NGLayoutAlgorithm. In this mode we
didn't handle repeated table sections correctly.

First of all, we wouldn't detect that the sections were repeatable at
all, because IsAvoidBreakValue() would return false, since the
constraint space says that we're not inside any block fragmentation (and
therefore break-inside:avoid should have no effect). Move that check
into code that's only run when at the first table box fragment.

Secondly, we were bypassing some code that was needed to detect that we
need to RelayoutAsLastTableBox() at this point. Fix that as well. We
could perhaps have set the is_known_to_be_last_table_box_ in
NGTableLayoutAlgorithm instead when in RelayoutWithoutFragmentation, but
fixing it this way instead seemed more robust, less convoluted, albeit a
bit more expensive, since we're performing an unnecessary layout pass at
the last table fragment (but that should really be no big deal).

Bug: 1410896
Change-Id: If63da5a7388bc7dbc70681195c079b9cbe03907e
Reviewed-on: https://chromium-review.googlesource.com/4208191
WPT-Export-Revision: 5a067116c4c400579e0d2c2002cb140b2335046f

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e925cf913bdfd0c8fa56eb4f0c98def54c843eeb

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

FAIL: 3

Chrome

FAIL: 3

Safari

PASS: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-break/table/repeated-section/repeated-section-in-clipped-overflow-001.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-break/table/repeated-section/repeated-section-in-clipped-overflow-002.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)
• /css/css-break/table/repeated-section/repeated-section-in-clipped-overflow-003.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: PASS)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bdb9e0fdce4a
[wpt PR 38285] - Fix for repeated table sections inside clipped container., a=testonly
https://hg.mozilla.org/integration/autoland/rev/70f9dc6d8094
[wpt PR 38285] - Update wpt metadata, a=testonly

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/bdb9e0fdce4a
https://hg.mozilla.org/mozilla-central/rev/70f9dc6d8094