Closed Bug 1814088 Opened 1 year ago Closed 9 months ago

WebGPU CTS fails in many tests: `this.queue.onSubmittedWorkDone is not a function`

Categories

(Core :: Graphics: WebGPU, defect, P1)

defect

Tracking

()

RESOLVED FIXED
118 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- disabled
firefox116 --- disabled
firefox117 --- disabled
firefox118 --- fixed

People

(Reporter: ErichDonGubler, Assigned: ErichDonGubler)

References

(Blocks 3 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(5 files)

Honestly, there's not a better description I could give to the title, ATM. Will edit accordingly once detail are better understood.

Link to repro: https://gpuweb.github.io/cts/standalone/?runnow=1&q=webgpu%3Aapi%2Coperation%2Cmemory_sync%2Cbuffer%2C*

No longer blocks: webgpu-cts
Regressed by: webgpu-cts

The severity field is not set for this bug.
:jimb, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jimb)
Severity: -- → S3
Priority: -- → P3

Seeing this on lots of shader tests in upstream CTS (but not our current vendored copy); they depend on GPUQueue.onSubmittedWorkDone here. This was introduced in this CTS commit. I think this bumps up the priority significantly.

Priority: P3 → P2
Summary: WebGPU CTS fails on `webgpu:api,operation,memory_sync,buffer,*`: `this.queue.onSubmittedWorkDone is not a function` → WebGPU CTS fails in many tests: `this.queue.onSubmittedWorkDone is not a function`

Priority: I agree.

Flags: needinfo?(jimb)
Assignee: nobody → egubler
Status: NEW → ASSIGNED
Priority: P2 → P1

Already got a working patch for this, so I guess that means it's a P1 now. 😆

Attachment #9348921 - Attachment description: WIP: Bug 1814088: feat(webgpu): implement `GPUQueue.onSubmittedWorkDone` r=#webgpu-reviewers → Bug 1814088: feat(webgpu): implement `GPUQueue.onSubmittedWorkDone` r=#webgpu-reviewers
See Also: → 1848993
Blocks: 1848993
See Also: 1848993
Blocks: 1849016

The final result of these tests are unaffected D186175, but that change
will //also// unblock enough of them that they (inasfar as I've
observed) //always// time out at some point in the middle of their
execution. Make all of them expect NOTRUN and TIMEOUT, so we don't
fail CI for now, with follow-up in bug 1848857 and bug 1848866.

The final result of these tests are unaffected D186175, but that change
will //also// unblock enough of them that they (inasfar as I've
observed) //always// time out at some point in the middle of their
execution. Make all of them expect NOTRUN and TIMEOUT, so we don't
fail CI for now, with follow-up in bug 1848993.

Depends on D186377

Some of these tests will start to pass in D186175, but that change will
//also// unblock enough of them that they (inasfar as I've observed)
//always// time out at some point in the middle of their execution. Make
all of them expect NOTRUN and TIMEOUT, so we don't fail CI for now,
with follow-up in bug 1849016.

Depends on D186378

Attachment #9349271 - Attachment description: Bug 1814088: test(webgpu): accept `{NOTRUN,TIMEOUT}` in all `memory_sync,buffer,{single_buffer,multiple_buffers}:rw:*` tests r=#webgpu-reviewers → Bug 1814088: test(webgpu): accept `{NOTRUN,TIMEOUT}` in all `memory_sync,buffer,{single_buffer,multiple_buffers}:*` tests r=#webgpu-reviewers
Pushed by egubler@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33ba9313b35c
test(webgpu): accept `{NOTRUN,TIMEOUT}` in all `copyTextureToTexture:copy_ranges:*` tests r=webgpu-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/24db87ec2b87
test(webgpu): accept `{NOTRUN,TIMEOUT}` in all `large_draw` tests r=webgpu-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/873431e409ce
test(webgpu): accept `{NOTRUN,TIMEOUT}` in all `memory_sync,buffer,{single_buffer,multiple_buffers}:*` tests r=webgpu-reviewers,nical
https://hg.mozilla.org/integration/autoland/rev/78ae45bac13c
feat(webgpu): implement `GPUQueue.onSubmittedWorkDone` r=webgpu-reviewers,webidl,smaug,nical
https://hg.mozilla.org/integration/autoland/rev/ef6bc324f847
typo(webgpu): `server.rs`: s/the the/the/ r=webgpu-reviewers,nical
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: