1814134 - Perma /builds/worker/checkouts/gecko/build/clang-plugin/StmtToBlockMap.h:56:13: error: use of undeclared identifier 'Optional'; did you mean 'optionally'?

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

[task 2023-01-31T09:21:38.136Z] 09:21:38    ERROR -  /builds/worker/checkouts/gecko/build/clang-plugin/StmtToBlockMap.h:56:13: error: use of undeclared identifier 'Optional'; did you mean 'optionally'?
[task 2023-01-31T09:21:38.136Z] 09:21:38     INFO -          if (Optional<CFGStmt> S = (*B)[I].getAs<CFGStmt>()) {
[task 2023-01-31T09:21:38.136Z] 09:21:38     INFO -              ^~~~~~~~
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -              optionally
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -  /builds/worker/fetches/clang/include/clang/ASTMatchers/ASTMatchers.h:2782:58: note: 'optionally' declared here
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -  extern const internal::VariadicOperatorMatcherFunc<1, 1> optionally;
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -                                                           ^
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -  In file included from /builds/worker/checkouts/gecko/build/clang-plugin/DiagnosticsMatcher.cpp:5:
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -  In file included from /builds/worker/checkouts/gecko/build/clang-plugin/DiagnosticsMatcher.h:8:
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -  In file included from /builds/worker/checkouts/gecko/build/clang-plugin/ChecksIncludes.inc:22:
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -  In file included from /builds/worker/checkouts/gecko/build/clang-plugin/MustReturnFromCallerChecker.h:9:
[task 2023-01-31T09:21:38.137Z] 09:21:38    ERROR -  /builds/worker/checkouts/gecko/build/clang-plugin/StmtToBlockMap.h:56:31: error: expected ')'
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -          if (Optional<CFGStmt> S = (*B)[I].getAs<CFGStmt>()) {
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -                                ^
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -  /builds/worker/checkouts/gecko/build/clang-plugin/StmtToBlockMap.h:56:12: note: to match this '('
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -          if (Optional<CFGStmt> S = (*B)[I].getAs<CFGStmt>()) {
[task 2023-01-31T09:21:38.137Z] 09:21:38     INFO -             ^
[task 2023-01-31T09:21:38.138Z] 09:21:38    ERROR -  /builds/worker/checkouts/gecko/build/clang-plugin/StmtToBlockMap.h:57:15: error: use of undeclared identifier 'S'
[task 2023-01-31T09:21:38.138Z] 09:21:38     INFO -            Map[S->getStmt()] = std::make_pair(B, I);
[task 2023-01-31T09:21:38.138Z] 09:21:38     INFO -                ^
[task 2023-01-31T09:21:38.138Z] 09:21:38     INFO -  3 errors generated.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1814134 - Fix clang plugin to build with recent clang trunk.

Clang trunk recently removed Optional (replaced with std::optional).

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea12a2ff5250
Fix clang plugin to build with recent clang trunk. r=firefox-build-system-reviewers,ahochheiden

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ea12a2ff5250