Closed Bug 1814202 Opened 1 year ago Closed 1 year ago

Perma Late Beta macOS 11 TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu_badiframe.js | Test timed out - when Gecko 111 switches to Late Beta 2023-02-24

Categories

(Firefox :: Menus, defect)

Product:
Firefox
Component:
Menus
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox109 --- unaffected
firefox110 --- unaffected
firefox111 --- verified

People

(Reporter: imoraru, Assigned: mconley)

References

Details

Attachments

(1 file)

Bug 1814202 - Make browser_contextmenu_badiframe.js more reliable. r?NeilDeakin!
48 bytes, text/x-phabricator-request
Details | Review

Failure log:

[task 2023-01-31T17:02:36.650Z] 17:02:36     INFO - TEST-PASS | browser/base/content/test/contextMenu/browser_contextmenu_badiframe.js | New tab should have page url, not about:neterror - 
[task 2023-01-31T17:02:36.650Z] 17:02:36     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "data:text/html,<frameset cols="400,400"><frame src="http://example.com/"><frame src="http://127.0.0.1:55555/"></frameset>" line: 0}]
[task 2023-01-31T17:02:36.650Z] 17:02:36     INFO - Console message: [JavaScript Warning: "Partitioned cookie or storage access was provided to “http://example.com/” because it is loaded in the third-party context and dynamic state partitioning is enabled."]
[task 2023-01-31T17:02:36.651Z] 17:02:36     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "http://example.com/" line: 0}]
[task 2023-01-31T17:02:36.651Z] 17:02:36     INFO - open frame in tab for http://127.0.0.1:55555/
[task 2023-01-31T17:02:36.651Z] 17:02:36     INFO - Console message: [JavaScript Error: "TypeError: doc is null" {file: "resource:///actors/ContextMenuChild.sys.mjs" line: 566}]
[task 2023-01-31T17:02:36.651Z] 17:02:36     INFO - Buffered messages finished
[task 2023-01-31T17:02:36.651Z] 17:02:36     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu_badiframe.js | Test timed out - 
[task 2023-01-31T17:02:36.651Z] 17:02:36     INFO - Not taking screenshot here: see the one that was previously logged
[task 2023-01-31T17:02:36.651Z] 17:02:36     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu_badiframe.js | Uncaught exception received from previously timed out test - popupshown listener on #contentAreaContextMenu not removed before the end of test
[task 2023-01-31T17:02:36.651Z] 17:02:36     INFO - Entering test bound testOpenFrameInWindow
[task 2023-01-31T17:02:36.652Z] 17:02:36     INFO - GECKO(3893) | Waiting for browser load
[task 2023-01-31T17:02:36.652Z] 17:02:36     INFO - GECKO(3893) | Waiting for browser state change
[task 2023-01-31T17:02:36.652Z] 17:02:36     INFO - GECKO(3893) | Saw state f0001 and status 0
[task 2023-01-31T17:02:36.652Z] 17:02:36     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "data:text/html,<frameset cols="400,400"><frame src="http://example.com/"><frame src="http://127.0.0.1:55555/"></frameset>" line: 0}]
[task 2023-01-31T17:02:36.652Z] 17:02:36     INFO - GECKO(3893) | Saw state f0001 and status 0
[task 2023-01-31T17:02:36.652Z] 17:02:36     INFO - GECKO(3893) | Saw state c0010 and status 804b000d
[task 2023-01-31T17:02:36.652Z] 17:02:36     INFO - GECKO(3893) | Saw state f0001 and status 0
[task 2023-01-31T17:02:36.652Z] 17:02:36     INFO - Console message: [JavaScript Warning: "Partitioned cookie or storage access was provided to “http://example.com/” because it is loaded in the third-party context and dynamic state partitioning is enabled."]
[task 2023-01-31T17:02:36.653Z] 17:02:36     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "http://example.com/" line: 0}]
[task 2023-01-31T17:02:36.653Z] 17:02:36     INFO - GECKO(3893) | Saw state c0010 and status 0
[task 2023-01-31T17:02:36.653Z] 17:02:36     INFO - GECKO(3893) | Saw state c0010 and status 0
[task 2023-01-31T17:02:36.653Z] 17:02:36     INFO - GECKO(3893) | Browser got expected state change data:text/html,<frameset cols="400,400"><frame src="http://example.com/"><frame src="http://127.0.0.1:55555/"></frameset>
[task 2023-01-31T17:02:36.834Z] 17:02:36     INFO - open frame in window for http://example.com/
[task 2023-01-31T17:02:36.982Z] 17:02:36     INFO - GECKO(3893) | 1675184556981	Marionette	TRACE	Received observer notification browser-delayed-startup-finished
[task 2023-01-31T17:02:36.994Z] 17:02:36     INFO - Console message: [JavaScript Warning: "This page is in Quirks Mode. Page layout may be impacted. For Standards Mode use “<!DOCTYPE html>”." {file: "http://example.com/" line: 0}]
[task 2023-01-31T17:02:36.995Z] 17:02:36     INFO - TEST-PASS | browser/base/content/test/contextMenu/browser_contextmenu_badiframe.js | New window should have page url, not about:neterror -

Hi Molly! Can you please take a look at this? Maybe you can see what could cause this.
Thank you!

Flags: needinfo?(mhowell)

@emilio, do you think this could be more fallout from bug 1805414?

Flags: needinfo?(mhowell) → needinfo?(emilio)

I don't see how. the doc is null exception seems relevant (here) and it seems the target is the document (since document.ownerDocument is the only time ownerDocument returns null). That should still happen way before the menu opens tho.

Flags: needinfo?(emilio)
Summary: Perma Late Beta TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu_badiframe.js | Test timed out - when Gecko 111 switches to Late Beta 2023-02-24 → Perma Late Beta macOS 11 TEST-UNEXPECTED-FAIL | browser/base/content/test/contextMenu/browser_contextmenu_badiframe.js | Test timed out - when Gecko 111 switches to Late Beta 2023-02-24
See Also: → 1775953

Here's a beta sim for that test directory try push with profiling: https://treeherder.mozilla.org/jobs?repo=try&revision=4c98c5962bc133fdf70340d213dae8cd4d15a9fa

ni'ing myself to examine this try push after the jobs finish.

Flags: needinfo?(mconley)
Assignee: nobody → mconley
Flags: needinfo?(mconley)

The test had a race condition in it where contextmenu events had a chance of
not targeting the right document if a subframe hadn't loaded and presented
in time. This patch uses BrowserTestUtils.browserLoaded and requestAnimationFrame
to help ensure that the subframes have both loaded and presented.

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6ac768943fa
Make browser_contextmenu_badiframe.js more reliable. r=NeilDeakin

https://hg.mozilla.org/mozilla-central/rev/a6ac768943fa

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox111: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: