1814242 - Make sure each WebTransport session only uses one connection when pooling is disabled

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Kershaw Chang [:kershaw]]

The spec says:

A WebTransport session is a session of WebTransport over HTTP/3. There may be multiple WebTransport sessions on one connection, when pooling is enabled.

But our current implementation allows multiple sessions to use the same UDP connection.

Comment 1

[Kershaw Chang [:kershaw]]

Attachment: Bug 1814242 - Ensure only one WebTransport session on one connection, r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f5c52611b43
Ensure only one WebTransport session on one connection, r=necko-reviewers,valentin

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on test_webtransport_simple.js

• backout: https://hg.mozilla.org/integration/autoland/rev/b1f877d80f9fed93d80bcda7dcb68f52f2ea78b4
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=dRrQPk3qT5mKGjjJvJQDyA.0&revision=7f5c52611b43d62b719b45baf965e24c60ab9547
• failure log: https://treeherder.mozilla.org/logviewer?job_id=404427169&repo=autoland&lineNumber=3564

[task 2023-02-02T23:35:29.721Z] 23:35:29     INFO -  TEST-START | netwerk/test/unit/test_webtransport_simple.js
[task 2023-02-02T23:40:29.724Z] 23:40:29  WARNING -  TEST-UNEXPECTED-TIMEOUT | netwerk/test/unit/test_webtransport_simple.js | Test timed out
[task 2023-02-02T23:40:29.724Z] 23:40:29     INFO -  TEST-INFO took 300000ms
[task 2023-02-02T23:40:29.734Z] 23:40:29     INFO -  >>>>>>>
[task 2023-02-02T23:40:29.735Z] 23:40:29     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2023-02-02T23:40:29.735Z] 23:40:29     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2023-02-02T23:40:29.736Z] 23:40:29     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2023-02-02T23:40:29.736Z] 23:40:29     INFO -  running event loop
[task 2023-02-02T23:40:29.737Z] 23:40:29     INFO -  netwerk/test/unit/test_webtransport_simple.js | Starting setup
[task 2023-02-02T23:40:29.737Z] 23:40:29     INFO -  (xpcshell/head.js) | test setup pending (2)
[task 2023-02-02T23:40:29.737Z] 23:40:29     INFO -  TEST-PASS | netwerk/test/unit/test_webtransport_simple.js | setup - [setup : 26] "51978" != null

Comment 4

[Ed Guloien [:edgul]]

Attachment: Bug 1814242 - Ensure only one WebTransport session on one connection, r=#necko

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8594f7460678
Ensure only one WebTransport session on one connection, r=necko-reviewers,valentin

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for xpcshell failure on test_webtransport_simple.js.

Backout link: https://hg.mozilla.org/integration/autoland/rev/331897d220e06950e62072f017cf8cefc7ad6497
Log link: https://treeherder.mozilla.org/logviewer?job_id=404540994&repo=autoland&lineNumber=3560

Comment 7

[Kershaw Chang [:kershaw]]

Attachment: Bug 1814242 - Close the connection when a webtransport session closed, r=#necko

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c6010e53475
Ensure only one WebTransport session on one connection, r=necko-reviewers,valentin
https://hg.mozilla.org/integration/autoland/rev/99e65d2014b4
Close the connection when a webtransport session closed, r=necko-reviewers,valentin

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/5c6010e53475
https://hg.mozilla.org/mozilla-central/rev/99e65d2014b4