Closed Bug 1814289 Opened 2 years ago Closed 4 months ago

Apply the new jsdoc eslint rules to the new translations component

Categories

(Firefox :: Translations, task, P2)

task

Tracking

()

RESOLVED FIXED
125 Branch
Tracking Status
firefox125 --- fixed

People

(Reporter: gregtatum, Assigned: gregtatum)

Details

Attachments

(2 files, 1 obsolete file)

In the review for the about:translations prototype, :mconley said:

Along with adding a new folder, now is a really good time to make sure that anything new that gets added in here abides by some stricter linting codes that are still coming down the pike.

An ESLint rule for requiring valid jsdoc is something I can recommend, for example: https://searchfox.org/mozilla-central/rev/8e9b4484408154b80d7ede9e1b035819fda48fd2/browser/components/migration/.eslintrc.js#8

I enabled the rule, but had some feedback. Rather than doing that in the initial prototype, this bug tracks that action.

Assignee: gtatum → nobody
No longer blocks: fx-translation

@Greg Tantum would like to work on this issue, as part of the translation task, i have setup the Firefox Project locally.

There will be lint errors reported, as the following patch will manually
fix the remaining errors.

Assignee: nobody → gtatum
Status: NEW → ASSIGNED
Attachment #9356693 - Attachment is obsolete: true
Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a7c7d576a78
Enable the jsdoc lint rule for translations and run auto-fix; r=translations-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/9f4bfb69a2bd
Manually fix jsdoc lint violations; r=translations-reviewers,nordzilla
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: