1814300 - S/MIME signature status display is broken/absent in comm-central version 111

Status: RESOLVED FIXED

(MailNews Core :: Security: S/MIME, defect)

Description

[Kai Engert (:KaiE:)]

Open a signed S/MIME message.
Bug: No S/MIME signature status is shown in the header area, the S/MIME label is missing.

Comment 1

[Kai Engert (:KaiE:)]

The regression is specifically with the status of S/MIME signature status.
S/MIME encryption status is still shown.

I still worked in nightly 2023-01-18, and it's broken in 2023-01-19,
it's unrelated to other recent changes to digital signature handling.

Comment 2

[Kai Engert (:KaiE:)]

The UI doesn't receive calls to smime header sink, signedStatus.
I'm guessing this regression was caused by bug 1799764 and the changes to the header sink.

I will debug whether the new code in mimecms.cpp and mimemcms.cpp actually works.

Comment 3

[Kai Engert (:KaiE:)]

The code to obtain the header sink from the channel probably works, because it works in the encrypted message scenario.

However, in the signed message scenario, we don't even reach function MimeMultCMS_init (mime multipart signed), so apparently something is wrong with the dispatcher for that MIME type?

Comment 4

[Kai Engert (:KaiE:)]

This change https://phabricator.services.mozilla.com/D162688
from bug 1799764
renamed variable EnigmailVerify.lastMsgWindow to lastWindow,
but it didn't rename references to that variable outside of that file.

Comment 5

[Kai Engert (:KaiE:)]

Attachment: Bug 1814300 - Fix recently regressed S/MIME signature status display. r=darktrojan

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b06278bcefd4
Fix recently regressed S/MIME signature status display. r=mkmelin

Comment 7

[Thomas D. (:thomas8)]

Updating whiteboard to [supernova3p]. 20230424_2303