1814345 - [Gmail] Text color selection is not respected

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[Ardelean Oana, Desktop QA [:oardelean]]

Attachment: Screen Recording 2023-02-01 at 11.19.35.mov

Notes

• This does not reproduce in Chrome. Please see the attached recording for more details.

Found in

• Nightly 111.0a1;

Affected versions

• Nightly 111.0a1;

Tested platforms

• macOS 12;
• Windows 10;
• Ubuntu 22;

Affected platforms

• macOS 12;
• Windows 10;
• Ubuntu 22;

Unaffected platforms

• N/A;

Steps to reproduce

1. Launch Nightly and go to http://mail.google.com .
2. Login with a valid account.
3. Click on the “Compose” button to open a new e-mail window.
4. From the editor, select any text color.
5. Write something in the e-mail.

Expected result

• Text color selection is respected.

Actual result

• Text color selection is not respected.

Regression range

• First bad: 2023-01-26
• Last good: 2023-01-25
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2e626352a4f6f0a7cb598d35d3ace53d4be7f284&tochange=0659120fb8f2386bbab75f04527a2854e0e6465e
• Potentially regressed by: bug 1811161

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1811161

:masayuki, since you are the author of the regressor, bug 1811161, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Odd, Gmail might use CSS color value. I'll fix this tomorrow.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I see, it's tricky.

Gmail calls document.execCommand("forecolor") with setting styleWithCSS to true. At this time, style editor preserves the color with rgb(..., ..., ...) style value. However, at typing text, styleWithCSS is set to false. Therefore, the CSS style color value is set to <font color>. Okay, we need to normalize the value when we pick the preserved style's color up.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1814345 - Make the style setter re-normalize color value when setting `<font color="...">` r=m_kato!

Gmail sets styleWithCSS to true before setting foreColor, then, sets
styleWithCSS to false before user typing text. Currently, we normalize
given color value to a proper value for current styling mode, and we have not
assumed that the mode is changed during preserving the style.

For solving this issue, HTMLEditor::AutoInlineStyleSetter::ApplyStyle should
normalize the given value again if the value is not proper for
<font color="..."> (at this moment, the color value is normalized to #XXXXXX
style or rgb(n, n, n) or rgba(n, n, n, n), therefore the check is simple in
this patch).

Then, I realized that according to editing/run/forecolor.html result [1],
the other browsers accept CSS color value as the parameter of foreColor
command. Therefore, this patch also allows it, thus, this patch fixes a lot of
WPT failures.

1. https://wpt.fyi/results/editing/run/forecolor.html%3F1-1000?sha=95f9b15d9a&label=master&max-count=1&view=subtest

Depends on D168179

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b0a20769286
Make the style setter re-normalize color value when setting `<font color="...">` r=m_kato

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38321 for changes under testing/web-platform/tests

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox111 (nightly). However, the bug still has low severity.

:hsinyi, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9b0a20769286

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Ardelean Oana, Desktop QA [:oardelean]]

Verified on Nightly 111.0a1(build ID: 20230203091639) on macOS 12, Windows 10, Ubuntu 22.