1814397 - Add/Edit top site form's URL and custom screenshot URL form validation are broken

Status: RESOLVED WORKSFORME

(Firefox :: New Tab Page, defect)

Description

[:prathiksha]

STR

1. Open the new tab page.
2. Try to add a top site or edit an existing top site tile. It should open a form in a dialog.
3. Enter something arbitrary like "pqrst" in the URL field and click on the Add or Save button.

Expected result:

Form validation is performed and an error tooltip is displayed if the URL is not valid. The dialog should stay open to allow the user to enter the correct URL.

Actual result:

The dialog closes and a top site tile is added. It doesn't map to anything valid.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:daleharvey, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[:prathiksha]

It appears form validation warnings in the add and edit top sites dialogs don't kick in for arbitrary strings because it's fixed up by cleanUrl() here https://searchfox.org/mozilla-central/rev/af78418c4b5f2c8721d1a06486cf4cf0b33e1e8d/browser/components/newtab/content-src/components/TopSites/TopSiteForm.jsx#168. I think this bug can be closed.