1814405 - The Download Mobile URL does not contain the experiment parameters when it is accessed from the treatment branches of the "Test Window modal vs Tab modal on about:welcome" experiment

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Simona Rosu [:srosu], Ecosystem QA]

Attachment: MobileLink_WrongParameters.gif

[Affected versions]:

• Firefox Beta 110.0b8 (Build ID: 20230131190033)

[Affected Platforms]:

• Windows 10 x64
• Windows 11 x64

[Prerequisites]:

• Have the latest version of Firefox Beta 110 installed and opened.
• Have the “nimbus.debug” and “devtools.chrome.enabled” prefs set to “true” in the “about:config” page.

[Steps to reproduce]:

1. Force enroll in the Treatment C branch of the experiment using the following link: about:studies?optin_slug=window-modal-vs-tab-modal&optin_branch=treatment-c&optin_collection=nimbus-preview
2. Focus the browser console and run the “Cc["@mozilla.org/browser/clh;1"].getService().wrappedJSObject.firstRunProfile = true; Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._maybeShowDefaultBrowserPrompt()” syntax.
3. Navigate through the Onboarding flow until the “Mobile” modal is shown.
4. Click the “Send yourself a download link instead” button.
5. Observe the URL’s parameters of the opened link.

[Expected result]:

• The URL contains a specific "utm_term "parameter for the experiment.

[Actual result]:

• The URL doesn’t contain a specific "utm_term" parameter for the experiment.

[Notes]:

• This issue is also reproducible in the Treatment A and B branches of the experiment.
• This issue is not reproducible on the Control branch of the experiment.
• Attached is a screen recording of the issue.

Comment 2

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:
Fix is needed to pass correct correct utm_term for new user onboarding window modal experiment in Fx110 . It's a one line fix that will be used only for window modal experiment

Comment 3

[Negin]

Attachment: Bug 1814405 - The Download Mobile URL does not contain the experiment UTM parameters when it is accessed from window modal

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f351cf2b878
The Download Mobile URL does not contain the experiment UTM parameters when it is accessed from window modal r=pdahiya

Comment 5

[Punam Dahiya [:pdahiya]]

NI @pasacal to weigh in and if possible consider attached patch for RC build uplift . Thanks!

Comment 6

[Punam Dahiya [:pdahiya]]

NI @srosu to help QA verify patch once attached patch is in Nightly thanks!

Comment 7

[Pascal Chevrel:pascalc (PTO until April 26)]

Punam, please fill in the uplift request form for beta, thanks.

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9f351cf2b878

Comment 9

[Negin]

Comment on attachment 9315725 [details]
Bug 1814405 - The Download Mobile URL does not contain the experiment UTM parameters when it is accessed from window modal

Beta/Release Uplift Approval Request

• User impact if declined: Unable to run Window Modal vs Tab Modal experiment due to missing experiment UTM field
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: Steps can be found in Phabricator patch
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One line fix to allow UTM term to be passed into window modal config and is covered by browser tests.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the latest Firefox Nightly 111.0a1 (Build ID: 20230203091639) on Windows 10 and 11x64.

• I confirm that the Download Mobile URL contains the “aboutwelcome-optin-window-modal-vs-tab-modal-treatment-a-screen” utm_term after the “Send yourself a download link instead” button from the “Mobile” modal is accessed.
• Based on the Test Plan, the utm_term for treatments B and C still needs to be updated on the recipe.

Comment 11

[Punam Dahiya [:pdahiya]]

@srosu as updated in test plan, can you please also confirm user gets enrolled (using normandy ids) in 'treatment-a' branch of the experiment without any schema validation error thanks!

Comment 12

[Simona Rosu [:srosu], Ecosystem QA]

Hi Punam! Thanks for reaching out to me! I confirm that the user gets enrolled in treatment-a branch of the experiment, and no validation errors appear in the Browser Console. I verify this using the latest Firefox Nightly 111.0a1 (Build ID: 20230203091639) on Windows 10 and 11x64

To verify this, I used the following steps:

• Installed the latest version of Firefox Nightly and added the "-p --first-startup" syntax to its target.
• Created a new profile but didn't open it.
• Pasted the user.js file into the browser's profile folder.
• Opened the browser profile.
• Observed that the new window modal is shown.
• Observed that the study is displayed on the "about:studies" page.
• Observed in the "about:telemetry#events" page that got enrolled in the treatment-a of the experiment.
• Observed that no errors are displayed on the Browser Console.

Comment 13

[Negin]

Hi Pascal!

Wondering if it's still possible to uplift this patch? Uplift request has been updated and QA has verified fix in nightly. Thanks and sorry for the last minute request!

Comment 14

[Donal Meehan [:dmeehan]]

(In reply to Negin from comment #13)

Hi Pascal!

Wondering if it's still possible to uplift this patch? Uplift request has been updated and QA has verified fix in nightly. Thanks and sorry for the last minute request!

This patch will be included in the next batch of uplifts, likely later today.
There won't be another 111 beta build, but it will be included in 111 RC1

Comment 15

[Donal Meehan [:dmeehan]]

Comment on attachment 9315725 [details]
Bug 1814405 - The Download Mobile URL does not contain the experiment UTM parameters when it is accessed from window modal

Approved for 110.0RC1

Comment 16

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6354716b245b

Comment 17

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this issue using the Firefox Release Candidate 110.0 (Build ID: 20230206190557) on Windows 10 and 11x64.

• I confirm that the Download Mobile URL contains the experiment UTM parameters when it is accessed from the window modal.