18145 - [MLK] Leaking nsBlockFrame in nsGfxTextControlFrame::Reflow()

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[Patrick C. Beard]

Look at the cvsblame URL above, you'll notice that you're creating an
nsBlockFrame instance, but if mDisplayFrame is already set, you're clobbering,
and leaking the previous one. This seems to happen once when running appRunner
and loading www.mozilla.org. It's a pretty significant leak, my leak report shows
this single object holding on to 18248 bytes.

Here's an experimental patch that fixes the leak, and also fixes an nsTextNode
leak, by using an nsCOMPtr.

Index: mozilla/layout/html/forms/src/nsGfxTextControlFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/forms/src/nsGfxTextControlFrame.cpp,v
retrieving revision 3.85
diff -r3.85 nsGfxTextControlFrame.cpp
1581,1582c1581,1582
<           nsIContent* content;
<           rv = NS_NewTextNode(&content);
---
>           nsCOMPtr<nsIContent> content;
>           rv = NS_NewTextNode(getter_AddRefs(content));
1622a1623,1626
>           if (mDisplayFrame) {
>             mDisplayFrame->Destroy(*mFramePresContext);
>             mDisplayFrame = nsnull;
>           }

Comment 1

[buster]

thanks, patrick.  I'll look at this over the weekend.

Comment 2

[buster]

fixed.  patrick, could you please verify when you get a chance?

Comment 3

[Chris Petersen]

I not sure how to verify this fix since I'm the assigned QA contact. Patrick ,
could you please mark this as fixed ?

Comment 4

[Chris Petersen]

Marking fixed per last comments.