1814656 - Intervention cards text is flickering while typing

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Petruta Horea [:phorea], Desktop QA]

Note

• Small regression affecting the intervention cards in Firefox 110 beta.
• Not reproducible in Nightly 111 after bug 1811870 landed.

Found in

• Firefox 110 beta 8

Affected versions

• Firefox 110 beta 8

Tested platforms

• Affected platforms: all
• Unaffected platforms:

Steps to reproduce

1. Type clear Firefox browser in address bar and check the intervention card

Expected result

• Intervention card flickers while typing

Actual result

• There is no flickering, intervention cards are correctly displayed

Regression range

• First bad: 2023-01-13
• Last good: 2023-01-12
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b7ce0bc6a79b14a75b02e7c322937625d5ba3af6&tochange=03202cdedb1ed88cdd7b6a8d4ac9e6d88300c0d4
• Potentially regressed by: 1809705

Additional notes
Bug 1811870 - Enable urlbar result menu in Nightly fixed this issue in 111, but considering urlbar result menu will be enabled by default only in 112, this might worth checking

Comment 1

[Dão Gottwald [:dao]]

I can confirm that this is still an issue in Nightly after setting browser.urlbar.resultMenu = false.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1814656 - Fix typo. r=adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0df0dfb9035
Fix typo. r=adw

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b0df0dfb9035

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 9315659 [details]
Bug 1814656 - Fix typo. r=adw

Beta/Release Uplift Approval Request

• User impact if declined: mostly a cosmetic issue
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: see comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): just fixing a typo
• String changes made/needed: none
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9315659 [details]
Bug 1814656 - Fix typo. r=adw

Approved for 110.0RC1

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/733a825d7a44

Comment 9

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed on Firefox 110RC (treeherder build) and latest Nightly 111.0a1 under Win 10 64-bit, Ubuntu 22 and OSX 10.14.