Closed Bug 1814693 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38331 - webrtc: remove video-rotation hdrext from list of mandatory to negotiate extensions

Categories

(Core :: WebRTC, task, P4)

Product:
Core
Component:
WebRTC
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38331 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38331
Details from upstream follow.

Philipp Hancke <phancke@microsoft.com> wrote:

webrtc: remove video-rotation hdrext from list of mandatory to negotiate extensions

The video rotation RTP header extension is mandatory to implement
but (unlike the mid extension) not mandatory to negotiate.
This came up in
https://webrtc-review.googlesource.com/c/src/+/286780

BUG=chromium:1051821

Change-Id: I40d36348908b305f557e2ebde30621b3b8a3396f

Reviewed-on: https://chromium-review.googlesource.com/4219133
WPT-Export-Revision: 8aac53d7fdbd76689a32b74e39322df9444766ec

Component: web-platform-tests → WebRTC
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 2[GitHub]
PASS: 2
FAIL: 1[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] 11[GitHub]

Chrome

OK : 2
PASS: 13

Safari

OK : 2
PASS: 3
FAIL: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /webrtc-extensions/RTCRtpTransceiver-headerExtensionControl.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
    • the video transceiver.headerExtensionsToOffer() includes mandatory extensions: FAIL (Chrome: PASS, Safari: FAIL)
    • the audio transceiver.headerExtensionsToOffer() includes mandatory extensions: FAIL (Chrome: PASS, Safari: FAIL)
    • setOfferedRtpHeaderExtensions throws TypeError on encountering missing URI: FAIL (Chrome: PASS, Safari: FAIL)
    • setOfferedRtpHeaderExtensions throws NotSupported on encountering unknown URI: FAIL (Chrome: PASS, Safari: FAIL)
    • setOfferedRtpHeaderExtensions throws InvalidModificationError when setting a mandatory header extension's direction to something else than "sendrecv": FAIL (Chrome: PASS, Safari: FAIL)
    • modified direction set by setOfferedRtpHeaderExtensions is visible in headerExtensionsOffered: FAIL (Chrome: PASS, Safari: FAIL)
    • unstopped extensions turn up in offer: FAIL (Chrome: PASS, Safari: FAIL)
    • stopped extensions do not turn up in offers: FAIL (Chrome: PASS, Safari: FAIL)
    • the set of negotiated extensions grows with subsequent offers: FAIL (Chrome: PASS, Safari: FAIL)
    • the set of negotiated extensions is the set of unstopped extensions: FAIL (Chrome: PASS, Safari: FAIL)
  • /webrtc/protocol/rtp-headerextensions.html [wpt.fyi]
    • Video orientation header extension is supported.: FAIL (Chrome: PASS, Safari: PASS)

Tests Disabled in Gecko Infrastructure

  • /webrtc-extensions/RTCRtpTransceiver-headerExtensionControl.html [wpt.fyi]: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2071c49e9150 [wpt PR 38331] - webrtc: remove video-rotation hdrext from list of mandatory to negotiate extensions, a=testonly https://hg.mozilla.org/integration/autoland/rev/6f0b4fc25033 [wpt PR 38331] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2071c49e9150
https://hg.mozilla.org/mozilla-central/rev/6f0b4fc25033

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.